Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(tsc) fix nouncheckedindexedaccess #82791

Merged
merged 18 commits into from
Jan 2, 2025
Merged

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Dec 31, 2024

Precursor to enabling ts noUncheckedIndexedAccess rule. The fixes here dont impact the runtime and only add type assertions. I will followup with a PR to do the same for getsentry before enabling the flag

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
8449 1 8448 0
View the top 1 failed tests by shortest run time
SlowestFunctionsWidget renders examples and chart
Stack Traces | 0.174s run time
ReferenceError: getAllByRole is not defined
    at Object.<anonymous> (.../profiling/landing/slowestFunctionsWidget.spec.tsx:247:21)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@JonasBa JonasBa marked this pull request as ready for review January 2, 2025 13:48
@JonasBa JonasBa requested review from a team as code owners January 2, 2025 13:48
@JonasBa JonasBa merged commit cf8c5bd into master Jan 2, 2025
41 of 42 checks passed
@JonasBa JonasBa deleted the jb/tsc/nouncheckedindexaccess branch January 2, 2025 13:48
andrewshie-sentry pushed a commit that referenced this pull request Jan 2, 2025
Precursor to enabling ts noUncheckedIndexedAccess rule. The fixes here
dont impact the runtime and only add type assertions. I will followup
with a PR to do the same for getsentry before enabling the flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants