Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(quick-start): Update backend enums names #83361

Merged
merged 5 commits into from
Jan 15, 2025
Merged

ref(quick-start): Update backend enums names #83361

merged 5 commits into from
Jan 15, 2025

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Jan 14, 2025 •
edited
Loading

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 14, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #83361      +/-   ##
==========================================
- Coverage   87.53%   87.53%   -0.01%     
==========================================
  Files        9406     9406              
  Lines      537301   537301              
  Branches    21154    21154              
==========================================
- Hits       470319   470306      -13     
- Misses      66637    66650      +13     
  Partials      345      345

@priscilawebdev priscilawebdev marked this pull request as ready for review January 14, 2025 13:19
@priscilawebdev priscilawebdev requested a review from a team January 14, 2025 13:20
@priscilawebdev priscilawebdev force-pushed the priscila/ref/quick-start/rename-variables branch from 5eae651 to ac49889 Compare January 15, 2025 12:35
@priscilawebdev priscilawebdev requested review from a team as code owners January 15, 2025 12:35
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@priscilawebdev priscilawebdev changed the base branch from priscila/ref/quick-start/clean-up-deprecated-code to master January 15, 2025 12:36
@priscilawebdev priscilawebdev force-pushed the priscila/ref/quick-start/rename-variables branch from ac49889 to 7e8cc1d Compare January 15, 2025 12:40
@priscilawebdev priscilawebdev removed the Scope: Backend Automatically applied to PRs that change backend components label Jan 15, 2025
@priscilawebdev priscilawebdev force-pushed the priscila/ref/quick-start/rename-variables branch from 50b4aae to a990593 Compare January 15, 2025 12:50
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 15, 2025
@priscilawebdev priscilawebdev enabled auto-merge (squash) January 15, 2025 12:52
@priscilawebdev priscilawebdev removed the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 15, 2025
@priscilawebdev priscilawebdev merged commit 361d204 into master Jan 15, 2025
49 checks passed
@priscilawebdev priscilawebdev deleted the priscila/ref/quick-start/rename-variables branch January 15, 2025 15:06
@asottile-sentry
Copy link
Member

this appears to break getsentry -- reverting

@asottile-sentry asottile-sentry added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jan 15, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: 0729289

getsentry-bot added a commit that referenced this pull request Jan 15, 2025
@getsentry-bot @asottile-sentry
Revert "ref(quick-start): Update backend enums names (#83361)"
0729289 
This reverts commit 361d204.

Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
@priscilawebdev
Copy link
Member Author

@asottile-sentry tests were not passing because of getsentry...but now they are ...weird! I need this PR merged https://github.com/getsentry/getsentry/pull/16145

priscilawebdev added a commit that referenced this pull request Jan 15, 2025
@priscilawebdev
Revert "ref(quick-start): Update backend enums names (#83361)"
2285364 
This reverts commit 361d204.
@priscilawebdev priscilawebdev mentioned this pull request Jan 15, 2025
Closed
@priscilawebdev priscilawebdev restored the priscila/ref/quick-start/rename-variables branch January 15, 2025 15:28
@priscilawebdev priscilawebdev mentioned this pull request Jan 15, 2025
Merged
@asottile-sentry
Copy link
Member

dependent PRs are not supported -- please find a way to make your change backward and forward compatible

@priscilawebdev
Copy link
Member Author

what do you mean by dependent PR? the "required" label no longer works?

@asottile-sentry
Copy link
Member

the "required" label is for you to test the impact of a change -- it's not meant to be merged with that present

@asottile-sentry
Copy link
Member

as per the develop docs: https://develop.sentry.dev/development-infrastructure/workflow/#testing-sentry-commits-in-getsentry

andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
@priscilawebdev @andrewshie-sentry
ref(quick-start): Update backend enums names (#83361)
4fea4a6
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
@getsentry-bot @asottile-sentry @andrewshie-sentry
Revert "ref(quick-start): Update backend enums names (#83361)"
e14712e 
This reverts commit 361d204.

Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellmayr shellmayr shellmayr approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@priscilawebdev @asottile-sentry @getsentry-bot @shellmayr