feat(nav): Move onboarding from drawer to overlay #85604
+185
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
malwilley
commented
Feb 20, 2025
•
malwilley
commented
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
Feb 20, 2025
| @@ -682,12 +678,6 @@ const TaskActions = styled('div')` | |||
| gap: ${space(1)}; | |||
| `; | |||
|
|
|||
| const BottomLeft = styled('img')` | |||
There was a problem hiding this comment.
Moved this to sidebar.tsx since it is not necessary in the overlay
malwilley
commented
Feb 20, 2025
| @@ -651,6 +646,8 @@ const TaskGroupWrapper = styled('div')` | |||
| border-radius: ${p => p.theme.borderRadius}; | |||
| padding: ${space(1)}; | |||
|
|
|||
| background-color: ${p => p.theme.background}; | |||
There was a problem hiding this comment.
This doesn't have an effect on the old sidebar panel since the background is already this color
malwilley
commented
Feb 20, 2025
| @@ -601,36 +599,33 @@ export function OnboardingSidebarContent({onClose}: OnboardingSidebarContentProp | |||
| }, [sortedGettingStartedTasks, sortedBeyondBasicsTasks]); | |||
|
|
|||
| return ( | |||
| <Fragment> | |||
| <Content> | |||
| <Content> | |||
There was a problem hiding this comment.
No real diff here, just removed the top level fragment
malwilley
commented
Feb 20, 2025
| @@ -119,38 +198,19 @@ export function PrimaryNavigationOnboarding() { | |||
| } | |||
|
|
|||
| return ( | |||
| <GuideAnchor target="onboarding_sidebar" position="right"> | |||
There was a problem hiding this comment.
Extracted this out to a new component
❌ 2 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 113.34kB (0.34%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.