feat(left-nav-views): Connect left nav views to backend #85608
Merged
+299
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
MichaelSun48
commented
Feb 21, 2025
Comment on lines
+44
to
+51
| const StyledHeader = styled(Layout.Header)` | ||
| background-color: ${p => p.theme.background}; | ||
| border: 0; | ||
| `; | ||
|
|
||
| const StyledHeaderContent = styled(Layout.HeaderContent)` | ||
| margin-bottom: 0; | ||
| `; |
There was a problem hiding this comment.
It would make more sense if these were variants of the Layout components, but this is a bit of an experiment to gauge reaction. If people like it, we can make it a "canon" variant
malwilley
reviewed
Feb 21, 2025
| )} | ||
| {!hasLeftNavIssueViews && | ||
| (organization.features.includes('issue-stream-custom-views') ? ( | ||
| organization.features.includes('issue-views-page-filter') ? ( |
There was a problem hiding this comment.
This is starting to get a little crazy hah. Might be time to remove the issue-views-page-filter feature flag
There was a problem hiding this comment.
Love me some triple nested feature flags 🤡
Yeah this has been on my backlog for a while, will get to it today!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds persistence functionality to all of the view mutation actions and removes the horizontal views from the issues page (for those that have the feature flag, of course)
Also updates the header design to have the same background as the container body, as per a impromptu conversation with Rachel & Vu