Skip to content

Conversation

DominikB2014
Copy link
Contributor

closes #performance sidebar

We've had redirects from performance -> insights for about 2 weeks. Now it's time to remove the performance sidebar link for good.

@DominikB2014 DominikB2014 requested a review from a team March 12, 2025 17:47
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
9701 1 9700 4
View the top 1 failed test(s) by shortest run time
Sidebar sidebar links in regular mode, also shows links to Performance and Crons
Stack Traces | 0.086s run time
Error: expect(received).toHaveLength(expected)

Expected length: 24
Received length: 23
Received array:  [<a class="css-1c6ahya-Link-linkStyles-StyledSidebarItem-StyledSidebarItem-StyledSidebarItem e88zkai7" href=".../organizations/org-slug/issues/?referrer=sidebar" id="sidebar-item-issues"><span class="css-mczp82-InteractionStateLayer-InteractionStateLayer e18pngx40" color="white" role="presentation" /><div class="css-1uxubju-SidebarItemWrapper e88zkai6"><span class="css-mwo12u-SidebarItemIcon e88zkai5"><svg fill="currentColor" height="14px" role="img" viewBox="0 0 16 16" width="14px"><path d="M13.24,16H2.74A2.75,2.75,0,0,1,0,13.26V2.76A2.75,2.75,0,0,1,2.74,0h10.5A2.75,2.75,0,0,1,16,2.76v10.5A2.75,2.75,0,0,1,13.24,16ZM2.74,1.51A1.25,1.25,0,0,0,1.49,2.76v10.5a1.25,1.25,0,0,0,1.25,1.25h10.5a1.25,1.25,0,0,0,1.25-1.25V2.76a1.25,1.25,0,0,0-1.25-1.25Z" /><rect height="1.5" width="14.5" x="0.74" y="2.61" /><rect height="1.5" width="14.5" x="0.74" y="5.26" /><path d="M10.79,12.08H5.19a1.25,1.25,0,0,1-1.25-1.25V9.42H.74V7.92h4.7v2.66h5.1V7.92h4.7v1.5H12v1.41A1.25,1.25,0,0,1,10.79,12.08Z" /></svg></span><span class="css-ken0y5-SidebarItemLabel e88zkai4"><div class="css-1yxb6zi-TextOverflow-overflowEllipsis-TruncatedLabel-TruncatedLabel e88zkai3">Issues</div></span></div></a>, <a class="css-1c6ahya-Link-linkStyles-StyledSidebarItem-StyledSidebarItem-StyledSidebarItem e88zkai7" href=".../organizations/org-slug/projects/" id="sidebar-item-projects"><span class="css-mczp82-InteractionStateLayer-InteractionStateLayer e18pngx40" color="white" role="presentation" /><div class="css-1uxubju-SidebarItemWrapper e88zkai6"><span class="css-mwo12u-SidebarItemIcon e88zkai5"><svg fill="currentColor" height="14px" role="img" viewBox="0 0 16 16" width="14px"><path d="M5.43,11.92a.73.73,0,0,1-.53-.22L3,9.82A.75.75,0,0,1,3,8.76L4.9,6.88A.75.75,0,0,1,6,7.94L4.61,9.29,6,10.64A.75.75,0,0,1,6,11.7.74.74,0,0,1,5.43,11.92Z" /><path d="M10.58,11.92a.74.74,0,0,1-.53-.22.75.75,0,0,1,0-1.06L11.4,9.29,10.05,7.94a.75.75,0,0,1,1.06-1.06L13,8.76a.74.74,0,0,1,0,1.06L11.11,11.7A.71.71,0,0,1,10.58,11.92Z" /><path d="M15.26,16H.76A.75.75,0,0,1,0,15.26V.76A.74.74,0,0,1,.76,0H5.12A2.75,2.75,0,0,1,6.77.56L8.51,1.87a1.3,1.3,0,0,0,.75.25h6a.76.76,0,0,1,.75.75V15.26A.76.76,0,0,1,15.26,16ZM1.51,14.51h13V3.62H9.26a2.75,2.75,0,0,1-1.65-.55L5.87,1.76h0a1.3,1.3,0,0,0-.75-.25H1.51Z" /></svg></span><span class="css-ken0y5-SidebarItemLabel e88zkai4"><div class="css-1yxb6zi-TextOverflow-overflowEllipsis-TruncatedLabel-TruncatedLabel e88zkai3">Projects</div></span></div></a>, <a aria-expanded="true" aria-owns="sidebar-accordion-explore-content" class="css-1c6ahya-Link-linkStyles-StyledSidebarItem-StyledSidebarItem-StyledSidebarItem e88zkai7" data-test-id="sidebar-accordion-explore-item" href="/mock-pathname/" id="sidebar-item-sidebar-accordion-explore-item"><span class="css-mczp82-InteractionStateLayer-InteractionStateLayer e18pngx40" color="white" role="presentation" /><div class="css-1uxubju-SidebarItemWrapper e88zkai6"><span class="css-mwo12u-SidebarItemIcon e88zkai5"><svg fill="currentColor" height="14px" role="img" viewBox="0 0 16 16" width="14px"><path d="M6,12A6,6,0,1,1,12,6,6,6,0,0,1,6,12ZM6,1.54A4.46,4.46,0,1,0,10.45,6,4.46,4.46,0,0,0,6,1.54Z" /><path d="M15.2,16a.74.74,0,0,1-.53-.22L9.14,10.2A.75.75,0,0,1,10.2,9.14l5.53,5.53a.75.75,0,0,1,0,1.06A.74.74,0,0,1,15.2,16Z" /></svg></span><span class="css-ken0y5-SidebarItemLabel e88zkai4"><div class="css-1yxb6zi-TextOverflow-overflowEllipsis-TruncatedLabel-TruncatedLabel e88zkai3">Explore</div></span><button aria-controls="sidebar-accordion-explore-item" aria-disabled="false" aria-label="Collapse" class="e17h31jk1 css-1n5ey8-StyledButton-getColors-SidebarAccordionExpandButton e140qn372" role="button" type="button"><span class="css-1cv7pa9-InteractionStateLayer-InteractionStateLayer-InteractionStateLayer-InteractionStateLayer e18pngx40" role="presentation" /><span class="css-1z0n9wg-ButtonLabel e140qn371"><svg class="css-t83efn-VariableWeightIcon eutdt120" role="presentation" stroke-opacity="1" viewBox="0 0 14 14"><path d="M3.5 8.5L7 5L10.5 8.5" /></svg></span></button></div></a>, <a class="css-1c6ahya-Link-linkStyles-StyledSidebarItem-StyledSidebarItem-StyledSidebarItem e88zkai7" href=".../organizations/org-slug/traces/" id="sidebar-item-performance-trace-explorer"><span class="css-mczp82-InteractionStateLayer-InteractionStateLayer e18pngx40" color="white" role="presentation" /><div class="css-1uxubju-SidebarItemWrapper e88zkai6"><span class="css-mwo12u-SidebarItemIcon e88zkai5"><div class="css-47cmxk-SubitemDot e1upz5ks3" /></span><span class="css-ken0y5-SidebarItemLabel e88zkai4"><div class="css-1yxb6zi-TextOverflow-overflowEllipsis-TruncatedLabel-TruncatedLabel e88zkai3">Traces</div></span></div></a>, <a class="css-1c6ahya-Link-linkStyles-StyledSidebarItem-StyledSidebarItem-StyledSidebarItem e88zkai7" href=".../organizations/org-slug/profiling/" id="sidebar-item-profiling"><span class="css-mczp82-InteractionStateLayer-InteractionStateLayer e18pngx40" color="white" role="presentation" /><div class="css-1uxubju-SidebarItemWrapper e88zkai6"><span class="css-mwo12u-SidebarItemIcon e88zkai5"><div class="css-47cmxk-SubitemDot e1upz5ks3" /></span><span class="css-ken0y5-SidebarItemLabel e88zkai4"><div class="css-1yxb6zi-TextOverflow-overflowEllipsis-TruncatedLabel-TruncatedLabel e88zkai3">Profiles</div></span></div></a>, <a class="css-1c6ahya-Link-linkStyles-StyledSidebarItem-StyledSidebarItem-StyledSidebarItem e88zkai7" href=".../organizations/org-slug/replays/" id="sidebar-item-replays"><span class="css-mczp82-InteractionStateLayer-InteractionStateLayer e18pngx40" color="white" role="presentation" /><div class="css-1uxubju-SidebarItemWrapper e88zkai6"><span class="css-mwo12u-SidebarItemIcon e88zkai5"><div class="css-47cmxk-SubitemDot e1upz5ks3" /></span><span class="css-ken0y5-SidebarItemLabel e88zkai4"><div class="css-1yxb6zi-TextOverflow-overflowEllipsis-TruncatedLabel-TruncatedLabel e88zkai3">Replays</div></span></div></a>, <a class="css-1c6ahya-Link-linkStyles-StyledSidebarItem-StyledSidebarItem-StyledSidebarItem e88zkai7" href=".../org-slug/discover/homepage/" id="sidebar-item-discover-v2"><span class="css-mczp82-InteractionStateLayer-InteractionStateLayer e18pngx40" color="white" role="presentation" /><div class="css-1uxubju-SidebarItemWrapper e88zkai6"><span class="css-mwo12u-SidebarItemIcon e88zkai5"><div class="css-47cmxk-SubitemDot e1upz5ks3" /></span><span class="css-ken0y5-SidebarItemLabel e88zkai4"><div class="css-1yxb6zi-TextOverflow-overflowEllipsis-TruncatedLabel-TruncatedLabel e88zkai3">Discover</div></span></div></a>, <a aria-expanded="true" aria-owns="sidebar-accordion-insights-domains-content" class="css-1c6ahya-Link-linkStyles-StyledSidebarItem-StyledSidebarItem-StyledSidebarItem e88zkai7" data-test-id="sidebar-accordion-insights-domains-item" href="/mock-pathname/" id="sidebar-item-sidebar-accordion-insights-domains-item"><span class="css-mczp82-InteractionStateLayer-InteractionStateLayer e18pngx40" color="white" role="presentation" /><div class="css-1uxubju-SidebarItemWrapper e88zkai6"><span class="css-mwo12u-SidebarItemIcon e88zkai5"><svg fill="currentColor" height="14px" role="img" viewBox="0 0 16 16" width="14px"><path d="M4.38,15.99c-.28,0-.54-.16-.67-.41L.09,8.34c-.19-.37-.04-.82.34-1.01.37-.18.82-.03,1.01.34l2.95,5.9L10.95.42c.13-.25.39-.41.67-.41h0c.28,0,.54.16.67.42l3.62,7.26c.19.37.03.82-.34,1.01-.37.18-.82.03-1.01-.34l-2.95-5.91-6.57,13.14c-.13.25-.39.41-.67.41Z" /></svg></span><span class="css-ken0y5-SidebarItemLabel e88zkai4"><div class="css-1yxb6zi-TextOverflow-overflowEllipsis-TruncatedLabel-TruncatedLabel e88zkai3">Insights</div></span><button aria-controls="sidebar-accordion-insights-domains-item" aria-disabled="false" aria-label="Collapse" class="e17h31jk1 css-1n5ey8-StyledButton-getColors-SidebarAccordionExpandButton e140qn372" role="button" type="button"><span class="css-1cv7pa9-InteractionStateLayer-InteractionStateLayer-InteractionStateLayer-InteractionStateLayer e18pngx40" role="presentation" /><span class="css-1z0n9wg-ButtonLabel e140qn371"><svg class="css-t83efn-VariableWeightIcon eutdt120" role="presentation" stroke-opacity="1" viewBox="0 0 14 14"><path d="M3.5 8.5L7 5L10.5 8.5" /></svg></span></button></div></a>, <a class="css-1c6ahya-Link-linkStyles-StyledSidebarItem-StyledSidebarItem-StyledSidebarItem e88zkai7" href=".../org-slug/insights/frontend/" id="sidebar-item-performance-domains-web"><span class="css-mczp82-InteractionStateLayer-InteractionStateLayer e18pngx40" color="white" role="presentation" /><div class="css-1uxubju-SidebarItemWrapper e88zkai6"><span class="css-mwo12u-SidebarItemIcon e88zkai5"><div class="css-47cmxk-SubitemDot e1upz5ks3" /></span><span class="css-ken0y5-SidebarItemLabel e88zkai4"><div class="css-1yxb6zi-TextOverflow-overflowEllipsis-TruncatedLabel-TruncatedLabel e88zkai3">Frontend</div></span></div></a>, <a class="css-1c6ahya-Link-linkStyles-StyledSidebarItem-StyledSidebarItem-StyledSidebarItem e88zkai7" href=".../org-slug/insights/backend/" id="sidebar-item-performance-domains-platform"><span class="css-mczp82-InteractionStateLayer-InteractionStateLayer e18pngx40" color="white" role="presentation" /><div class="css-1uxubju-SidebarItemWrapper e88zkai6"><span class="css-mwo12u-SidebarItemIcon e88zkai5"><div class="css-47cmxk-SubitemDot e1upz5ks3" /></span><span class="css-ken0y5-SidebarItemLabel e88zkai4"><div class="css-1yxb6zi-TextOverflow-overflowEllipsis-TruncatedLabel-TruncatedLabel e88zkai3">Backend</div></span></div></a>, …]
    at Object.<anonymous> (.../components/sidebar/index.spec.tsx:342:21)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: , but also yikes :p

Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@DominikB2014 DominikB2014 enabled auto-merge (squash) March 12, 2025 18:02
@DominikB2014 DominikB2014 merged commit c9413c7 into master Mar 12, 2025
41 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/remove-perf-landing-sidebar branch March 12, 2025 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove performance link from navigation

3 participants