feat(shared-views): Hoist starred views to the top of GET list #88851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
MichaelSun48
commented
Apr 4, 2025
Comment on lines
-21
to
-24
|
|
||
|
|
||
| class GroupSearchViewStarredSerializerResponse(GroupSearchViewSerializerResponse): | ||
| position: int |
There was a problem hiding this comment.
Drive by change, this class was not used anywhere.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88851 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 10072 10072
Lines 569655 569681 +26
Branches 22372 22372
=======================================
+ Hits 499766 499803 +37
+ Misses 69490 69479 -11
Partials 399 399 |
armenzg
approved these changes
Apr 7, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
This PR updates the `GET` `/group-search-views/` logic to hoist starred views to the top when the createdBy query param is passed into the request. Also updates the response schema to include a `starred: boolean` field that way the frontend knows which views are starred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
GET/group-search-views/logic to hoist starred views to the top when the createdBy query param is passed into the request.Also updates the response schema to include a
starred: booleanfield that way the frontend knows which views are starred.