Skip to content

feat(taskworker) Add support for glob rollout rates #88853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

markstory
Copy link
Member

We have 300+ tasks. That will be a lot of data to read out of options in aggregate. For smaller deployments, small namespaces, or when we have completed a namespace we could use a wildcard - * to apply the same rollout rate to all tasks. The task specific rollout rate would take precedence over the wildcard rate.

We have 300+ tasks. That will be a lot of data to read out of options
in aggregate. For smaller deployments, small namespaces, or when we have
completed a namespace we could use a wildcard - `*` to apply the same
rollout rate to all tasks. The task specific rollout rate would take
precedence over the wildcard rate.
@markstory markstory requested a review from a team April 4, 2025 21:09
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 4, 2025
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tests/sentry/tasks/test_taskworker_rollout.py 90.47% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #88853       +/-   ##
===========================================
+ Coverage   32.97%   87.73%   +54.75%     
===========================================
  Files        8512    10072     +1560     
  Lines      475426   569678    +94252     
  Branches    22372    22372               
===========================================
+ Hits       156780   499801   +343021     
+ Misses     318247    69478   -248769     
  Partials      399      399               

Copy link
Member

@evanh evanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we also want to support wildcard suffixes? E.g.
{"test.low_rate": 0.5, "test.low_*": 0.1}

@markstory
Copy link
Member Author

Would we also want to support wildcard suffixes? E.g. Would we also want to support wildcard suffixes? E.g.

Maybe? I was thinking of using this glob implementation as a catch-all for after namespaces are migrated and we want to simplify our options data.

@markstory markstory merged commit 1de3f7e into master Apr 7, 2025
50 checks passed
@markstory markstory deleted the feat-taskbroker-rollout-glob branch April 7, 2025 18:47
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We have 300+ tasks. That will be a lot of data to read out of options in
aggregate. For smaller deployments, small namespaces, or when we have
completed a namespace we could use a wildcard - `*` to apply the same
rollout rate to all tasks. The task specific rollout rate would take
precedence over the wildcard rate.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants