feat(aci): add type and creator cell components #88862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
|
are we adding the columns to the index page in this PR? or just the gridCells? |
|
@ameliahsu just adding the grid cells in this PR, since my other branch has the types refactor and also cleans up table props. |
natemoo-re
changed the title
natemoo-re
force-pushed
the
aci/nm/columns
branch
from
e46db98 to
96700b3
Compare
ameliahsu
reviewed
Apr 7, 2025
| disabled?: boolean; | ||
| }; | ||
|
|
||
| export function UserCell({user, disabled = false, className}: UserCellProps) { |
There was a problem hiding this comment.
should there be a tooltip here with the user's email or name? not sure if this is the expected behavior when you hover 😅
saponifi3d
reviewed
Apr 8, 2025
natemoo-re
force-pushed
the
aci/nm/columns
branch
from
bc4b057 to
e6a378b
Compare
natemoo-re
force-pushed
the
aci/nm/columns
branch
from
e6a378b to
a99fa2f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88862 +/- ##
===========================================
- Coverage 86.49% 75.25% -11.25%
===========================================
Files 10107 10107
Lines 571949 571949
Branches 22474 22474
===========================================
- Hits 494723 430403 -64320
- Misses 76789 141109 +64320
Partials 437 437 |
natemoo-re
force-pushed
the
aci/nm/columns
branch
from
e4197dd to
fb67e77
Compare
ameliahsu
approved these changes
Apr 10, 2025
MichaelSun48
pushed a commit
that referenced
this pull request
Apr 11, 2025
Adds two new cells to the Workflow Engine components—type and user cell <img width="357" alt="Screenshot 2025-04-07 at 5 43 59 PM" src="https://github.com/user-attachments/assets/bd21cdef-a4af-4541-92a8-9b1fbb135cf2" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new cells to the Workflow Engine components—type and user cell