chore(org member invite): changes to organization member to support organization member invite changes #88867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mifu67
commented
Apr 4, 2025
mifu67
commented
- Prevent saving an existing OrganizationMember object if it's associated with an OrganizationMemberInvite object
- Prevent serializing OrganizationMember objects that are associated with OrganizationMemberInvite objects
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88867 +/- ##
========================================
Coverage 87.73% 87.73%
========================================
Files 10072 10077 +5
Lines 569659 570112 +453
Branches 22372 22372
========================================
+ Hits 499769 500201 +432
- Misses 69491 69512 +21
Partials 399 399 |
cathteng
reviewed
Apr 7, 2025
Comment on lines
129
to
131
| return Response( | ||
| {"detail": "Cannot serialize details for a placeholder organization member"}, | ||
| status=400, |
There was a problem hiding this comment.
should this respond 404? it's like the org member doesn't exist right?
There was a problem hiding this comment.
similarly we can prevent editing by returning 404 on the org member details endpoint?
There was a problem hiding this comment.
I missed the PUT, thanks for catching
cathteng
approved these changes
Apr 7, 2025
| @@ -123,6 +125,9 @@ def get( | |||
|
|
|||
| Response will be a pending invite if it has been approved by organization owners or managers but is waiting to be accepted by the invitee. | |||
| """ | |||
| invite = OrganizationMemberInvite.objects.filter(organization_member_id=member.id).first() | |||
There was a problem hiding this comment.
can we move this check to _get_member? then you don't have to repeat it for GET, PUT, DELETE. didn't notice the extra function above
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…rganization member invite changes (#88867) - Prevent saving an existing OrganizationMember object if it's associated with an OrganizationMemberInvite object - Prevent serializing OrganizationMember objects that are associated with OrganizationMemberInvite objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.