Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: pipenv lockfile #9026

Closed
wants to merge 3 commits into from
Closed

dev: pipenv lockfile #9026

wants to merge 3 commits into from

Conversation

joshuarli
Copy link
Member

@joshuarli joshuarli commented Jul 12, 2018

I first generated a lockfile from an up-to-date dev environment with pipenv lock. Because the Pipfile only has sentry as an editable install requirement with all the extras, the lockfile can always be kept up to date without manual Pipfile editing or pipenv install calls - simply invoke pipenv lock after editing our requirements files which will get picked up by setuptools using our setup.py.

Basically, this PR adds a pipenv lockfile without really impacting our current workflow.

So the virtualenvs are nearly identical:

$ mkvirtualenv -p /Users/josh/.pyenv/versions/2.7.15/bin/python2.7 sentry
$ pip install -e ".[dev,tests,optional]"
$ pip freeze > /tmp/sentry
$ deactivate
$ mkvirtualenv -p /Users/josh/.pyenv/versions/2.7.15/bin/python2.7 sentry-pipenv
$ pipenv install
$ diff -u /tmp/sentry /tmp/sentry-pipenv
--- /tmp/sentry 2018-08-02 14:15:54.000000000 -0700
+++ /tmp/sentry-pipenv  2018-08-02 14:22:24.000000000 -0700
@@ -2,6 +2,7 @@
 anyjson==0.3.3
 apipkg==1.5
 asn1crypto==0.24.0
+atomicwrites==1.1.5
 attrs==18.1.0
 autopep8==1.3.5
 Babel==2.6.0

I don't really know why pipenv installed atomicwrites. It isn't a subdependency of anything, and so can be removed from the lockfile.

@joshuarli joshuarli changed the title [WIP] pipenv lockfile [WIP] build: adopt pipenv Jul 12, 2018
name = "pypi"

[packages]
"e1839a8" = {editable = true, path = ".", extras = ["optional", "dev", "tests"]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this problematic?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pypa/pipfile#93 (comment) Can we change the name to just 'sentry'?

@joshuarli joshuarli changed the title [WIP] build: adopt pipenv dev: pipenv lockfile Aug 2, 2018
@joshuarli
Copy link
Member Author

closing; see discussion on python-poetry/poetry#794

@joshuarli joshuarli closed this Jan 14, 2019
@joshuarli joshuarli deleted the build/pipenv branch August 15, 2019 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants