Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first generated a lockfile from an up-to-date dev environment with
pipenv lock
. Because thePipfile
only has sentry as an editable install requirement with all the extras, the lockfile can always be kept up to date without manualPipfile
editing orpipenv install
calls - simply invokepipenv lock
after editing our requirements files which will get picked up bysetuptools
using oursetup.py
.Basically, this PR adds a pipenv lockfile without really impacting our current workflow.
So the virtualenvs are nearly identical:
I don't really know why pipenv installed atomicwrites. It isn't a subdependency of anything, and so can be removed from the lockfile.