Skip to content

feat(taskworker) Add taskname dimension to execute_task metric #91844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

feat(taskworker) Add taskname dimension to execute_task metric #91844

merged 1 commit into from
May 20, 2025

Conversation

markstory
Copy link
Member

Having a taskname tag on this metric will let folks do throughput breakdowns per task.

@markstory
feat(taskworker) Add taskname dimension to execute_task metric
6e09ac2 
Having a taskname tag on this metric will let folks do throughput
breakdowns per task.
@markstory markstory requested a review from a team as a code owner May 16, 2025 22:23
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 16, 2025
@codecov Codecov
Copy link

codecov bot commented May 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157001 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #91844       +/-   ##
===========================================
+ Coverage   32.73%   87.65%   +54.92%     
===========================================
  Files        8741    10348     +1607     
  Lines      487207   586487    +99280     
  Branches    22554    22554               
===========================================
+ Hits       159477   514103   +354626     
+ Misses     327284    71938   -255346     
  Partials      446      446

@markstory markstory merged commit db7f754 into master May 20, 2025
60 checks passed
@markstory markstory deleted the feat-task-throughput branch May 20, 2025 15:34
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
@markstory @andrewshie-sentry
feat(taskworker) Add taskname dimension to execute_task metric (#91844)
d529fed 
Having a taskname tag on this metric will let folks do throughput
breakdowns per task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

@enochtangg enochtangg enochtangg approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markstory @untitaker @enochtangg