Skip to content

Conversation

@asottile-sentry
Copy link
Contributor

when these were converted from PKEY to int columns the indexes were left but the state did not reflect that

when these were converted from PKEY to int columns the indexes were left but the state did not reflect that
@asottile-sentry asottile-sentry requested review from a team as code owners May 19, 2025 21:35
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 19, 2025
@github-actions
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0903_missing_indexes_in_state.py

for 0903_missing_indexes_in_state in sentry

--
-- Custom state/database change combination
--
-- (no-op)

@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157341 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #91901       +/-   ##
===========================================
+ Coverage   42.02%   87.62%   +45.60%     
===========================================
  Files       10331    10356       +25     
  Lines      585944   586960     +1016     
  Branches    22585    22585               
===========================================
+ Hits       246249   514341   +268092     
+ Misses     339267    72191   -267076     
  Partials      428      428               

@asottile-sentry asottile-sentry merged commit ad8f1ae into master May 19, 2025
61 checks passed
@asottile-sentry asottile-sentry deleted the asottile-more-missing-indexes branch May 19, 2025 23:42
jan-auer added a commit that referenced this pull request May 20, 2025
* master: (58 commits)
  link: cleanup link (#91687)
  ref: create project_id index for organizationonboardingtask (#91918)
  storybook: smaller last edited (#91875)
  issues: fix chonk stacktrace alignment (#91891)
  alert: drop custom alert (#91892)
  insights: fix bar height (#91895)
  ref(span-buffer): Move max-memory-percentage to right CLI (#91924)
  ref(js): Factor button functionality (#91763)
  tests(resolve_groups): Clean up the tests (#91779)
  ref(span-buffer): Add backpressure (#91707)
  fix(nextjs-insights): project id is not passed to explore link (#91920)
  fix(crons): Floor seconds / microsecond on recorded dateClock (#91890)
  fix(uptime): Fix bug with the uptime_checks dataset in the events endpoint (#91824)
  ref: add state-only migration to reflect existing indexes in prod (#91901)
  ref: remove unnecssary metaclass (#91906)
  fix(stats): use data category title name (#91913)
  feat(issues): Add success messages to some actions (#91899)
  test(taskworker): Lower exec time (#91907)
  chore(aci): manually add spans for delayed workflow processing (#91908)
  chore(aci): remove uses of WorkflowFireHistory rollout columns (#91904)
  ...
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
…1901)

when these were converted from PKEY to int columns the indexes were left
but the state did not reflect that


<!-- Describe your PR here. -->
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants