Skip to content

fix(uptime): Handle body better for methods without one #93111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Jun 9, 2025

  • When chaining methods from POST -> GET (or similar), do not display
    the body in the preview HTTP request.

  • Clear the body when saving and a body was previously set.

  • Include OPTIONS in disallowed body methods

Fixes: RTC-1004: Uptime Monitoring - GET req includes body
Fixes: #84934
Replaces: #93001

Requires: #93110

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner June 9, 2025 15:48
@evanpurkhiser evanpurkhiser requested a review from a team June 9, 2025 15:48
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 9, 2025
- When chaining methods from POST -> GET (or similar), do not display
  the body in the preview HTTP request.

- Clear the body when saving and a body was previously set.

- Include `OPTIONS` in disallowed body methods

Fixes: [RTC-1004: Uptime Monitoring - GET req includes body](https://linear.app/getsentry/issue/RTC-1004/uptime-monitoring-get-req-includes-body)
Fixes: #84934
Replaces: #93001
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/fix-uptime-handle-body-better-for-methods-without-one branch from f9d0321 to 93f64fe Compare June 9, 2025 16:52
@evanpurkhiser evanpurkhiser merged commit d43f91b into master Jun 9, 2025
42 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/fix-uptime-handle-body-better-for-methods-without-one branch June 9, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uptime Monitoring - GET req includes body
2 participants