feat(mql): Add support for unary operator #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
commented
Mar 7, 2024
| unary_op, coefficient = children | ||
| if unary_op: | ||
| if isinstance(coefficient, float) or isinstance(coefficient, int): | ||
| return -coefficient |
There was a problem hiding this comment.
We can more efficiently negate directly the scalar instead of using a formula.
evanh
reviewed
Mar 7, 2024
snuba_sdk/mql/mql.py
Outdated
| @@ -109,6 +113,10 @@ class InvalidMQLQueryError(Exception): | |||
| "/": ArithmeticOperator.DIVIDE.value, | |||
| } | |||
|
|
|||
| UNARY_OPERATORS: Mapping[str, str] = { | |||
| "-": ArithmeticOperator.MINUS.value, | |||
There was a problem hiding this comment.
Clickhouse uses the negate function for this, Clickhouse expects the minus function to have 2 arguments.
snuba_sdk/mql/mql.py
Outdated
| elif isinstance(coefficient, Formula) or isinstance( | ||
| coefficient, Timeseries | ||
| ): | ||
| return Formula(function_name=unary_op[0], parameters=[0, coefficient]) |
There was a problem hiding this comment.
Why does this have two parameters? Is that to support minus()? If so, we should use negate().
There was a problem hiding this comment.
Oh I didn't know there was that function, will use that!
evanh
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for unary operator
-on numeric scalars and timeseries/formulas, which was requested by some users.