feat(replay): add replays required timestamp col to ENTITY_TIME_COLUMNS #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanh
approved these changes
Oct 2, 2024
|
@aliu39 Let me know if you need help releasing. |
aliu39
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 3, 2024
…y tag key queries (#78534) This lets us query OrganizationTagsEndpoint with dataset=replays. - Use the newest snuba-sdk release, with change made in getsentry/snuba-sdk#197. - disable sampling optimization ("turbo") as replays table doesn't support it. - adds a test which I verified is working with snuba devserver, on branch getsentry/snuba#6378 Ref #78531 -> depends on getsentry/snuba#6378.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this for this query in Sentry's tagstore backend. Currently the
replaysentity does not support auto-filling the timestamp conditions, and we get 400 bad request,"detail": "Missing >= condition with a datetime literal on column timestamp for entity replays. Example: timestamp >= toDateTime('2023-05-16 00:00')".(The autofilling is done in snuba_sdk's
json_to_snqlfunction.)Impact: we can't search for custom tags in the replays dataset until we release this, and bump sentry's snuba-sdk version.