Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): Promote profiles and functions to complete #4238

Merged
merged 1 commit into from
May 26, 2023

Conversation

enochtangg
Copy link
Member

Overview

The PR will enable migrations for the profiles and functions datasets in self-hosted. Since we have migrated to readiness_states this PR is now stale. This change required for getsentry/self-hosted#2154.

Note: Setting profiles and functions to readiness_state: complete will not allow migrations on single-tenant as these groups still exist in SKIPPED_MIGRATION_GROUPS.

@enochtangg enochtangg requested a review from phacops May 24, 2023 16:29
@enochtangg enochtangg requested a review from a team as a code owner May 24, 2023 16:29
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9d503a9) 90.84% compared to head (cad956f) 90.84%.

❗ Current head cad956f differs from pull request most recent head c8c1362. Consider uploading reports for the commit c8c1362 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4238   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files         780      780           
  Lines       38456    38456           
  Branches      225      225           
=======================================
  Hits        34936    34936           
  Misses       3485     3485           
  Partials       35       35           
Impacted Files Coverage Δ
snuba/migrations/groups.py 97.82% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@enochtangg enochtangg merged commit 57fc592 into master May 26, 2023
@enochtangg enochtangg deleted the promote-functions-profiles-to-complete branch May 26, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants