-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(ch-upgrades): create dist tables functionality #5737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found
Additional details and impacted files@@ Coverage Diff @@
## master #5737 +/- ##
=========================================
Coverage ? 91.95%
=========================================
Files ? 863
Lines ? 41949
Branches ? 0
=========================================
Hits ? 38575
Misses ? 3374
Partials ? 0 ☔ View full report in Codecov by Sentry. |
nikhars
reviewed
Apr 10, 2024
nikhars
approved these changes
Apr 11, 2024
Co-authored-by: Nikhar Saxena <84807402+nikhars@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time we run the series of these pipelines (fetcher, replayer, comparer) we first have to bring up nodes from backups and have our test clusters to work with. Doing the backup will restore the local tables, along with the data, but usually the dist tables are not backed up (if we change our backup process maybe we can change this) but as of now SRE folks would have to manually create the dist tables.
This aims to save the schemas of the dist tables during the fetching process, and when replaying for the first time we should be downloading the schema and using it to create the tables.
I tested this locally with my own gcs bucket