feat(devexp): Add required_time_column to storage

[volokluev]

In order to allow storage queries to be validated based on timestamp, we need to know what their timestamp is. Entities already have this so we add this optional field to storages as well.

[codecov]

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2130 tests with 1 failed, 2127 passed and 2 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite: pytest Test name: tests.query.snql.test_storage_query::test_parse_storage_query[basic_storage_query] Envs: - default

Traceback (most recent call last): File ".../query/snql/parser.py", line 1554, in parse_snql_query _post_process(query, [_replace_time_condition], settings) File ".../query/snql/parser.py", line 1490, in _post_process func(query) File ".../query/snql/parser.py", line 1323, in _replace_time_condition new_top_level = _align_max_days_date_align( ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../query/snql/parser.py", line 1355, in _align_max_days_date_align data_source = get_storage(key) ^^^^^^^^^^^^^^^^ File ".../datasets/storages/factory.py", line 76, in get_storage storage = _storage_factory().get(storage_key) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../datasets/storages/factory.py", line 34, in get return self._all_storages[storage_key] ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^ KeyError: StorageKey.METRIC_SUMMARIES During handling of the above exception, another exception occurred: Traceback (most recent call last): File ".../query/snql/test_storage_query.py", line 185, in test_parse_storage_query query = parse_snql_query(query_body, events) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../query/snql/parser.py", line 1565, in parse_snql_query raise PostProcessingError(query) snuba.query.parser.exceptions.PostProcessingError: None