fix(error): Skip lineno deserialization on failure #5983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-z-yang
force-pushed
the
john/lineno-default-on-err
branch
from
23f7979
to
172564d
Compare
john-z-yang
force-pushed
the
john/lineno-default-on-err
branch
from
172564d
to
63a1a0c
Compare
volokluev
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Relay can send
linenofield as a u64, but in clickhouse, we are only storing them as u32. This pr changes the behaviour of the error consumer when it encounters alinenogreater than a u32, instead of failing, it uses the default value (None).