ref(async-inserts): add clickhouse-concurrency cli arg #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Jun 4, 2024
MeredithAnya
force-pushed
the
meredith/SNS-2781
branch
from
4339bc5
to
0d6e36c
Compare
anonrig
approved these changes
Jun 6, 2024
nachivrn
pushed a commit
that referenced
this pull request
Jun 6, 2024
* ref(async-inserts): add clickhouse-concurrency cli arg * add async inserts check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the clickhouse concurrency allows us to increase the amount of in-flight batches to clickhouse. Because async inserts does buffering on the clickhouse side, increasing the batches in flight won't increase the inserts/sec.
If async inserts aren't turned on it should stay at the previously hardcoded concurrency of 2