[CapMan visibility] sets throttle policy correctly #6088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayirr7
reviewed
Jul 2, 2024
| policy_name=allocation_policy.config_key(), | ||
| ) | ||
| if allowance.max_threads < num_threads: | ||
| throttle_quota_and_policy = _QuotaAndPolicy( |
There was a problem hiding this comment.
Is this basically saying to set some sort of query throttling if we want to allocate a lower max threads ?
ayirr7
approved these changes
Jul 2, 2024
kneeyo1
added a commit
that referenced
this pull request
Jul 8, 2024
kneeyo1
added a commit
that referenced
this pull request
Jul 8, 2024
xurui-c
added a commit
that referenced
this pull request
Aug 13, 2024
…a when multiple throttle policies present (#6192) Redo of #6088 because it got reverted Let's say the list of allocation policies that validates a query is [Policy1, Policy2, Policy3]. Suppose Policy2 throttles the query with 2 threads, and Policy3 throttles the query with 3 threads. The current logic will incorrectly say that the query is throttled by the last policy in the list (Policy3) with the minimum allocated threads across all policies in the list (2 threads). This PR correctly sets the query to run with 2 threads as throttled by Policy2 Co-authored-by: Rachel Chen <rachelchen@PL6VFX9HP4.attlocal.net>
xurui-c
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The throttle policy should be the policy with the smallest number of threads. The existing logic simply takes the last throttling policy in the
for-loop