Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replays): Set platform as empty string if platform is not provided #6098

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

cmanallen
Copy link
Member

Previously it was set to javascript as that was the only platform replay was available on. With the addition of mobile replays this is no longer true. The query in sentry already uses the anyIf operator and filters out empty values.

Related: getsentry/sentry#74074

@cmanallen cmanallen requested review from a team as code owners July 10, 2024 14:26
@michellewzhang
Copy link
Member

does this mean that if someone were to refresh the page on a mobile replay (referencing the video @romtsn sent), the platform in the tags panel might sometimes disappear (instead of changing to javascript)?

@cmanallen
Copy link
Member Author

@michellewzhang No if a non-empty value is set it will always be returned. There should only be one non-empty value. If there are two (in the case @romtsn identified) then one of the non-empty values will be chosen at "random".

@michellewzhang
Copy link
Member

@michellewzhang No if a non-empty value is set it will always be returned. There should only be one non-empty value. If there are two (in the case @romtsn identified) then one of the non-empty values will be chosen at "random".

makes sense!

@cmanallen cmanallen requested a review from a team July 10, 2024 17:07
Copy link
Member

@ayirr7 ayirr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also be a good idea to update any schema examples in the sentry-kafka-schemas repo if needed.

@cmanallen
Copy link
Member Author

@ayirr7 All good. Platform is not provided on any of the affected events.

@cmanallen cmanallen merged commit b4ddbc3 into master Jul 10, 2024
32 checks passed
@cmanallen cmanallen deleted the cmanallen/replays-set-platform-as-empty branch July 10, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants