Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait on system.mutations between hosts during migration execution #6121

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

kylemumma
Copy link
Member

@kylemumma kylemumma commented Jul 17, 2024

changes

Now when migrations are executed, the migration will not move on from 1 host to the next one until select count(*) from system.mutations where is_done=0 is 0

testing

Not sure how to do a comprehensive test of this but heres how i tested:

  • in the case where no mutation in progress, this works. I successfully ran a normal migration locally.
  • in the case of a mutation in progress I wasnt able to directly test, but I tested with is_done=1 to make sure the count(*) results were good ([(13,)]) so i think it should work

@kylemumma kylemumma changed the title init fix: wait on system.mutations between hosts during migration execution Jul 18, 2024
@kylemumma kylemumma marked this pull request as ready for review July 18, 2024 20:43
@kylemumma kylemumma requested a review from a team as a code owner July 18, 2024 20:43
Copy link
Member

@nikhars nikhars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree with Oliver's comment about the exception raised.

@kylemumma kylemumma merged commit cac887c into master Jul 19, 2024
25 of 27 checks passed
@kylemumma kylemumma deleted the krm/migration-sleep branch July 19, 2024 20:02
@chipzzz
Copy link

chipzzz commented Aug 13, 2024

@kylemumma , thank you for this, on replicated/sharded CH encountering the zookeeper error was painful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants