Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(eap): Move V0 implementations to their own directory #6329

Closed
wants to merge 3 commits into from
Closed

ref(eap): Move V0 implementations to their own directory #6329

wants to merge 3 commits into from

Conversation

volokluev
Copy link
Member

Making room for the V1 of this API (specified in getsentry/sentry-protos#28)

moving the existing implementations to their own folder so we can support backwards compatibility

@volokluev volokluev requested review from a team as code owners September 19, 2024 22:14
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2634 1 2633 4
View the top 1 failed tests by shortest run time 
tests.web.rpc.test_trace_item_attribute_values.TestTraceItemAttributes test_basic
Stack Traces | 0.21s run time 
Traceback (most recent call last):
  File ".../web/rpc/test_trace_item_attribute_values.py", line 104, in test_basic
    assert response.status_code == 200
AssertionError: assert 405 == 200
 +  where 405 = <WrapperTestResponse streamed [405 METHOD NOT ALLOWED]>.status_code

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@volokluev volokluev closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@volokluev