fix: fix broken admin error message displays #6439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error messages in the snuba admin tool haven't been showing up properly on some of the tools. my previous pr #6390 tried to address this, you can see it for an example of the issue.
unfortunately this change fixed the error messages on "system query" tool but broke them on "production query tool".
I have since found out this is because the error messages come from the execute_button component which is used across many different pages, and receives a variety of different looking error variables as input. Related to #6280.
In this PR I updated the logic again and verified across all pages that use the execute button that the error display looks good.