Limit focused events to session-captured trace IDs

[dcramer]

Adjust the behavior of Traces and Errors to show events which are associated with a known-local trace ID. If no trace IDs are known, assume all events should be present instead.

Fixes #188

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
spotlightjs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 4, 2023 7:40pm

[codecov]

Codecov Report

Attention: 96 lines in your changes are missing coverage. Please review.

Comparison is base (c538cd0) 32.47% compared to head (97fe540) 32.21%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
...y/src/integrations/sentry/components/EventList.tsx	16.12%	26 Missing ⚠️
...y/src/integrations/sentry/components/TraceList.tsx	20.00%	20 Missing ⚠️
...tegrations/sentry/components/HiddenItemsButton.tsx	10.00%	18 Missing ⚠️
.../src/integrations/sentry/data/useSentryHelpers.tsx	38.46%	8 Missing ⚠️
packages/overlay/src/integrations/sentry/index.ts	0.00%	8 Missing ⚠️
...ay/src/integrations/sentry/data/sentryDataCache.ts	75.00%	6 Missing ⚠️
packages/overlay/src/components/Badge.tsx	28.57%	5 Missing ⚠️
...rlay/src/integrations/sentry/sentry-integration.ts	16.66%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
- Coverage   32.47%   32.21%   -0.27%     
==========================================
  Files          39       42       +3     
  Lines        1869     1993     +124     
  Branches       71       71              
==========================================
+ Hits          607      642      +35     
- Misses       1262     1351      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dcramer]

One note - Sentry's Remix integration, and there's probably more, is currently not able to handle SSR errors.

That is, if you load a route, and it hits the top level ErrorBoundary, we fail to propagate the trace headers correctly. That means in this regard the error is shown as "in another session" because we've got an active frontend trace. However, that frontend trace is also detached from the backend hydration because of that same issue.

[dcramer]

getsentry/sentry-javascript#9737

[Lms24]

I generally really like this change! We should be aware that the limitation you mentioned for Remix also exists for Astro SSR error pages (e.g. astro playground /ssr-error page) but maybe that's also okay. In fact, this might just trigger the fallback logic to show all events.

[Lms24]

I'm gonna wait with merging #228 until this is merged (if we still wanna merge before tomorrow).

[dcramer]

Will follow up with a GH issue tracking this + an experimental flag for it. The Astro SSR case - at least in our playground - bypasses all session local logic so in that case the behavior is ok.