Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More structured parsing of Il2cpp SourceInfo #517

Merged
merged 10 commits into from
Jun 3, 2022

Conversation

Swatinem
Copy link
Member

No description provided.

@Swatinem Swatinem marked this pull request as draft March 17, 2022 14:24
@loewenheim loewenheim force-pushed the feat/il2cpp-mapping branch from 7db6b97 to 7a427ae Compare June 2, 2022 12:53
@loewenheim
Copy link
Contributor

Right now this only exposes the create_line_mapping_from_object function (and its return type, the type alias RawLineMapping). Arguably it would be cleaner to make the only function one that combines create_line_mapping_from_object with serialization to JSON so that RawLineMapping is entirely internal.

@loewenheim loewenheim marked this pull request as ready for review June 2, 2022 13:12
@loewenheim loewenheim requested a review from a team June 2, 2022 13:12
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #517 (878650c) into master (8c9eabc) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage   66.96%   66.77%   -0.20%     
==========================================
  Files         101      102       +1     
  Lines       18885    18941      +56     
==========================================
+ Hits        12646    12647       +1     
- Misses       6239     6294      +55     

@Swatinem
Copy link
Member Author

Swatinem commented Jun 2, 2022

That would also be perfectly fine. You could parse that into an opaque struct, which has as its only method a to_write or serialize which writes stuff to a T: Write.

Copy link
Member Author

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t approve my own PR :-D
I think rust complains because you never pub use this in the main lib.rs.

@loewenheim
Copy link
Contributor

That sounds like a good idea, yeah.

@loewenheim
Copy link
Contributor

I can’t approve my own PR :-D I think rust complains because you never pub use this in the main lib.rs.

Ah, I was wondering about that.

}
}

/// Extracts the `(file, line)` information
Copy link
Contributor

@kamilogorek kamilogorek Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an example line here in the comment, so its easier to understand the parsing in the future?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an example.

@loewenheim loewenheim merged commit b736c22 into master Jun 3, 2022
@loewenheim loewenheim deleted the feat/il2cpp-mapping branch June 3, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants