-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: More structured parsing of Il2cpp SourceInfo #517
Conversation
7db6b97
to
7a427ae
Compare
Right now this only exposes the |
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
==========================================
- Coverage 66.96% 66.77% -0.20%
==========================================
Files 101 102 +1
Lines 18885 18941 +56
==========================================
+ Hits 12646 12647 +1
- Misses 6239 6294 +55 |
That would also be perfectly fine. You could parse that into an opaque struct, which has as its only method a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can’t approve my own PR :-D
I think rust complains because you never pub use
this in the main lib.rs
.
That sounds like a good idea, yeah. |
Ah, I was wondering about that. |
} | ||
} | ||
|
||
/// Extracts the `(file, line)` information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add an example line here in the comment, so its easier to understand the parsing in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an example.
No description provided.