Revert "Support for DWARFv5 embedded source code extension (#849)" #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-wilfert
approved these changes
Oct 1, 2024
loewenheim
added a commit
to getsentry/symbolicator
that referenced
this pull request
Oct 1, 2024
This removes support for DWARF embedded sources. See getsentry/symbolic#870.
loewenheim
added a commit
to getsentry/symbolicator
that referenced
this pull request
Oct 1, 2024
This removes support for DWARF embedded sources. See getsentry/symbolic#870.
loewenheim
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 1, 2024
This removes support for embedded sources in DWARF, the root cause of #78251. See getsentry/symbolic#870.
loewenheim
added a commit
to getsentry/sentry-cli
that referenced
this pull request
Nov 4, 2024
This pulls in getsentry/symbolic#870.
szokeasaurusrex
pushed a commit
to getsentry/sentry-cli
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the "feature part" of commit 7dc28dd (#849). The dep updates can stay.
Unfortunately opening a debug session to check for the presence of sources is prohibitively expensive in terms of memory (going from ~450MB to ~3.7GB in a Python process that calls
Object.featureson an example 1.3GB file). In order to support this we'll have to find a more parsimonious way to check if a file contains sources.A simpler way to accomplish the same thing would be to restore
ElfObject::has_sourcesandWasmObject::has_sourcesto their previous implementations (just returnfalse) and leaving the rest of the changes intact.