feat(demangle): Import libswift demangle 6.0.3 #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dav1dde
force-pushed
the
dav1d/swift-603
branch
from
cb4fa95 to
6b896eb
Compare
Swatinem
approved these changes
Jan 9, 2025
loewenheim
approved these changes
Jan 9, 2025
d-e-s-o
added a commit
to d-e-s-o/symbolic
that referenced
this pull request
Jan 13, 2025
The 12.13.0 release and pull request getsentry#885 specifically broke GitHub Action based Windows builds. The reason seems to be that the Swift library upgrade now relies on C++17 features and the GitHub Actions Windows image uses MSVC 2022, which requires an explicit opt-in to those. The provided -std=c++17 works on GCC and similar, but does not have any effect on MSVC. To fix the build, add the flag that MSVC understands for opting in to the new standard. Signed-off-by: Daniel Müller <deso@posteo.net>
loewenheim
pushed a commit
that referenced
this pull request
Jan 14, 2025
The 12.13.0 release and pull request #885 specifically broke GitHub Action based Windows builds. The reason seems to be that the Swift library upgrade now relies on C++17 features and the GitHub Actions Windows image uses MSVC 2022, which requires an explicit opt-in to those. The provided -std=c++17 works on GCC and similar, but does not have any effect on MSVC. To fix the build, add the flag that MSVC understands for opting in to the new standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #884, #873
changes-meaningwarning which causes compilation failures on recent GCCs (fine on clang). Demangle entrypoint is now guarded bySWIFT_STDLIB_HAS_TYPE_PRINTING.This did need some manual patch-up of the
NodePrinter.cppwhich usesendswithinstead ofends_with. I suspect this is because the llvm sources checked out are newer than 6.0.3 was intended to be built with, at that pointendswithwas still available (but deprecated).I manually had to add the
InvertibleProtocols.defheader file, the update script did not automatically discover it. On a quick glance I couldn't see why not, this is something to look into in a follow-up or just keep it as a manual step.One of the test cases now has a different demangling, all the others still pass, I updated it: