Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Start using github actions for CI #235
ci: Start using github actions for CI #235
Changes from 46 commits
7d274cc
307e226
ec5cfa8
5c2de66
28ec04f
b8987e1
62aeebe
45f5b8f
42b372f
6bf746b
c7a85a4
f4246c7
f094376
ffbce5f
35c8161
b39509b
2e82d0c
461a70c
78f0f7e
e7633be
8d42e5b
5b75aa2
1c31851
c3ecc44
a9abbf7
c2c818f
cc75a77
a2da557
6383459
a31286d
d4b4681
e20f55b
d5056bc
bd33e88
1f428b9
4295645
cba53cc
ce0e9e6
50f1135
82b7b14
561bb8b
b3d10bb
52dbb17
2eb130e
9ede8d1
eafab8a
a090f8c
6045095
75c176f
49dc5ef
60088f3
bc5771b
f11e867
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: should we use this directly instead of makefile for symbolic as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're going with explicit commands now, I would say yes. The makefile becomes an interface for the developer, and CI has it's own (equivalent or equal) commands.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory this kind of stuff could be monitored by measuring coverage on the testsuite itself. Then you can find tests that are improperly skipped or not discovered at all for whatever reason.
In practice it's much harder to set up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that could work if you have a 100% test coverage enforced. But anything less and it probably doesn't. I like one global that you can use to potentially skip things on local workstations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean testing coverage of the code in
tests/
, not the code that is being tested. Surely all tests are running in CI?