Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use symbolic with increased demangler recursion limit #252

Merged
merged 3 commits into from
Jul 22, 2020
Merged

fix: Use symbolic with increased demangler recursion limit #252

merged 3 commits into from
Jul 22, 2020

Conversation

Swatinem
Copy link
Member

This is a companion to:

We can temporarily point this to a git dependency in order to figure out what an effect this has on our demangling failure rate.

@Swatinem Swatinem requested a review from a team July 20, 2020 09:49
jan-auer
jan-auer approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jan-auer jan-auer changed the title fix: Temporarily use a symbolic with an increased demangler recursion limit fix: Use symbolic with increased demangler recursion limit Jul 22, 2020
@jan-auer jan-auer merged commit 43fd431 into master Jul 22, 2020
@jan-auer jan-auer deleted the fix/demangle-recursion branch July 22, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swatinem @jan-auer