Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid SDKs must import <Sentry/PrivateSentrySDKOnly.h> explicit #66

Closed
6 tasks done
brustolin opened this issue Oct 21, 2022 · 14 comments
Closed
6 tasks done

Hybrid SDKs must import <Sentry/PrivateSentrySDKOnly.h> explicit #66

brustolin opened this issue Oct 21, 2022 · 14 comments

Comments

@brustolin
Copy link

brustolin commented Oct 21, 2022

Hybrids SDKs, when using PrivateSentrySDKOnly class, have to implicitly import <Sentry/PrivateSentrySDKOnly.h> alongside <Sentry/Sentry.h>.

We plan to remove PrivateSentrySDKOnly.h from the public header in the next major.

@marandaneto
Copy link

This affects all the platforms that ship the Cocoa SDK, such as Cordova, Capacitor, etc.
cc @kahest since you are collaborating with some of those.

@marandaneto marandaneto moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Oct 27, 2022
@marandaneto
Copy link

For Flutter since it uses Swift, we have to create a Module I guess.
https://stackoverflow.com/questions/32149371/import-objective-c-framework-into-swift-framework-google-analytics-cocoapod

@lucas-zimerman
Copy link

lucas-zimerman commented Oct 31, 2022

@marandaneto It may also affect Maui?
@brustolin Is there any Alpha/Beta version with this change?

@brustolin
Copy link
Author

@marandaneto
Copy link

@brustolin I didn't find an easy way to do that on Flutter, maybe it requires specific tweaks because its Swift, or is there an easy way?
See #66 (comment)

@brustolin
Copy link
Author

brustolin commented Nov 3, 2022

@marandaneto we need a different strategy for Flutter.
We need this approved.
But dont worry, I will do this for Flutter.

@brustolin
Copy link
Author

@bitsandfoxes I believe Unity is already setup this way right? Nothing to do there.

@brustolin
Copy link
Author

Hey @mattjohnsonpint. I believe this don't apply to Maui, can you confirm?

Since .NET references objc classes with an Attribute

[BaseType (typeof(NSObject), Name="PrivateSentrySDKOnly")]

You dont actually need to import a header explicit, is this correct?

@brustolin
Copy link
Author

@marandaneto Is Cordova SDK dead?
It is really outdated, it uses a Sentry cocoa version that didn't even have the PrivateSentrySDKOnly yet.

@marandaneto
Copy link

@marandaneto Is Cordova SDK dead? It is really outdated, it uses a Sentry cocoa version that didn't even have the PrivateSentrySDKOnly yet.

IDK the state of Cordova, maybe @kahest

@kahest
Copy link
Member

kahest commented Nov 3, 2022

We'll look into that, we should have the numbers. Also @brustolin can we close getsentry/sentry-cordova#291 then?

@brustolin
Copy link
Author

brustolin commented Nov 3, 2022

We'll look into that, we should have the numbers. Also @brustolin can we close getsentry/sentry-cordova#291 then?

Yes. When we update Cordova, we do it with this in mind.

@mattjohnsonpint
Copy link

You dont actually need to import a header explicit, is this correct?

Correct. The headers were only used when we generated the bindings initially. We should be fine, as long as the definitions don't change. If they do, then we can update manually.

@brustolin
Copy link
Author

Migration complete!!

Repository owner moved this from Backlog to Done in Mobile & Cross Platform SDK Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants