-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hybrid SDKs must import <Sentry/PrivateSentrySDKOnly.h> explicit #66
Comments
This affects all the platforms that ship the Cocoa SDK, such as Cordova, Capacitor, etc. |
For Flutter since it uses Swift, we have to create a Module I guess. |
@marandaneto It may also affect Maui? |
@brustolin I didn't find an easy way to do that on Flutter, maybe it requires specific tweaks because its Swift, or is there an easy way? |
@marandaneto we need a different strategy for Flutter. |
@bitsandfoxes I believe Unity is already setup this way right? Nothing to do there. |
Hey @mattjohnsonpint. I believe this don't apply to Maui, can you confirm? Since .NET references objc classes with an Attribute
You dont actually need to import a header explicit, is this correct? |
@marandaneto Is Cordova SDK dead? |
IDK the state of Cordova, maybe @kahest |
We'll look into that, we should have the numbers. Also @brustolin can we close getsentry/sentry-cordova#291 then? |
Yes. When we update Cordova, we do it with this in mind. |
Correct. The headers were only used when we generated the bindings initially. We should be fine, as long as the definitions don't change. If they do, then we can update manually. |
Migration complete!! |
Hybrids SDKs, when using
PrivateSentrySDKOnly
class, have to implicitly import<Sentry/PrivateSentrySDKOnly.h>
alongside<Sentry/Sentry.h>
.We plan to remove
PrivateSentrySDKOnly.h
from the public header in the next major.MauiCordovaThe text was updated successfully, but these errors were encountered: