Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same default environment #73

Open
4 of 5 tasks
philipphofmann opened this issue Nov 21, 2022 · 3 comments
Open
4 of 5 tasks

Use same default environment #73

philipphofmann opened this issue Nov 21, 2022 · 3 comments

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Nov 21, 2022

The default value for the environment in the options should be production. If the user sets an environment, it precedes the default value. Sessions, transactions, events, etc., should all read the environment from the options. The SDK can set other default values if it detects different modes, such as debug or test.

On Cocoa, we have a bug where sessions don't use the default environment from the options. Not setting an environment at all leads to different environments for events and transactions. Please validate that your SDK uses the correct default value:

Tasks

  1. Effort: Small Impact: Medium Platform: Cocoa Status: Backlog
    kevinrenskers
  2. Effort: Small Impact: Medium Platform: Android Platform: Java Type: Bug
    lbloder
  3. Platform: React-Native
    krystofwoldrich
@marandaneto
Copy link

Since Android and iOS don't set/read the environment, RN and Flutter sessions won't contain the default/custom environment, this has to be fixed first on the Native SDKs.
Flutter events are already set/read from the options, but sessions are handled by the native SDKs.
I believe RN has the same issue as Flutter, @krystofwoldrich to double check.

@krystofwoldrich
Copy link
Member

Events and Transaction have the default production set by the JS SDK,
Sessions are managed by the Native SDKs.

RN doesn't set any default environment by itself, it only passes the set env value to the native SDKs if there is any value.

@marandaneto
Copy link

Can RN detect if it's a release or debug build? if so, we can do that, otherwise, it is production by default, something to be addressed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

4 participants