sessions sent without an environment when environment option is not set - Android

[kerenkhatiwada]

Description

Similar to getsentry/sentry-cocoa#2411

If the environment is not set for the SDK errors will default to production. However, sessions are sent without an environment.

Expected outcome: sessions would be sent with an environment
Actual outcome: sessions are sent without an environment set

Steps To Reproduce

1. set the environment and release options
2. Send an error event and session
3. Observe that session and error event with the correct environment
4. repeat without setting the environment option
5. Observe the error event with an environment of production
6. Observe the session with no environment

[romtsn]

Let's double-check it everywhere (events, transactions, etc.)

[lbloder]

Events (event, exception, message) and Transactions are processed by the MainEventProcessor, which sets the default environment if the environment is null on both the Event and SentryOptions then the default is used.

So, I'm thinking of moving options.getEnvironment() != null ? options.getEnvironment() : DEFAULT_ENVIRONMENT from the MainEventProcessor to the getEnvironment() method of the SentryOptions. That should fix the problem and not introduce any duplication.
@romtsn WDYT?

[romtsn]

@lbloder sounds reasonable, but this way we'd always set production even if users want to intentionally set environment to null (don't know if that could be ever useful though). At least on Cocoa we've just set the default environment to production in SentryOptions, so that should do probably? getsentry/sentry-cocoa#2447

[romtsn]

ah, I see, they actually prohibited setting null values on Cocoa in addition. Alright then your suggestion totally makes sense!