-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong default environment in Session #2610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lbloder
changed the title
Default value for environment in SentryOptions
Fix wrong default environment in Session
Mar 17, 2023
Performance metrics 🚀
|
romtsn
reviewed
Mar 21, 2023
romtsn
approved these changes
Mar 21, 2023
adinauer
approved these changes
Mar 22, 2023
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2610 +/- ##
============================================
- Coverage 81.31% 81.31% -0.01%
Complexity 4187 4187
============================================
Files 336 336
Lines 15486 15485 -1
Branches 2021 2020 -1
============================================
- Hits 12592 12591 -1
Misses 2101 2101
Partials 793 793
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
The environment getter in
SentryOptions
now returns "production" as default if not set.💡 Motivation and Context
Fixes #2381
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps