ref: cleanup binary for self-hosted #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
reviewed
Jul 6, 2023
There was a problem hiding this comment.
I'm not sure why we'd need a dedicated binary to do that when this command will do the same thing and be implemented nicely in self-hosted:
find ${SENTRY_BUCKET_PROFILES} -type f -mtime +${SENTRY_EVENT_RETENTION_DAYS} -deleteFor now, I don't think we should merge this.
| @@ -6,6 +6,8 @@ COPY . . | |||
|
|
|||
| RUN GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -o . -ldflags="-s -w -X main.release=$(git rev-parse HEAD)" ./cmd/vroom | |||
|
|
|||
| RUN GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -o . -ldflags="-s -w" ./cmd/cleanup | |||
There was a problem hiding this comment.
We don't need this on another line, we can add ./cmd/cleanup to the line above.
| @@ -18,6 +20,8 @@ ENV SENTRY_BUCKET_PROFILES=file://localhost/$PROFILES_DIR | |||
|
|
|||
| COPY --from=builder /src/vroom /bin/vroom | |||
|
|
|||
| COPY --from=builder /src/cleanup /bin/cleanup | |||
There was a problem hiding this comment.
We should change the COPY above to include /src/cleanup instead.
|
@phacops Please see getsentry/self-hosted#2211 (comment) |
|
@phacops regarding getsentry/self-hosted#2211 (comment), can you please close this PR when you've migrated vroom to Debian? Or should I also do the base image migration? |
|
Closing in favor of #290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that tackles getsentry/self-hosted#2211 (comment) and getsentry/self-hosted#2211 (comment) on event that people at Sentry don't want to use an external cron scheduler, and wanted to put it as a vroom extension (of sorts).
I don't think I'll have any free time during next two weeks, meaning I'll be late to response. To mitigate that, I'll just create this one and let you guys decide it.
To apply this on
self-hostedrepo, I (or someone) just need to modify this on thedocker-compose.ymlfile:Closes #268
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.