Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support writing functions metrics we extract from chunks into the functions dataset #524

Merged

Conversation

viglia
Copy link
Contributor

@viglia viglia commented Oct 29, 2024

This adds support for ingesting functions metrics extracted from a chunk into to the functions dataset.

functions dataset

this is meant to move from generic metrics (where chunks functions metrics are currently stored) to the functions dataset.
@viglia viglia marked this pull request as ready for review October 29, 2024 10:31
@viglia viglia requested a review from a team as a code owner October 29, 2024 10:31
@viglia viglia self-assigned this Oct 30, 2024
cmd/vroom/chunk.go Outdated Show resolved Hide resolved
cmd/vroom/kafka.go Show resolved Hide resolved
@viglia viglia requested a review from Zylphrex October 31, 2024 09:37
internal/metrics/metrics.go Outdated Show resolved Hide resolved
internal/nodetree/nodetree.go Show resolved Hide resolved
@viglia viglia requested a review from Zylphrex October 31, 2024 15:37
@viglia viglia merged commit 8fe7db5 into main Nov 4, 2024
12 checks passed
@viglia viglia deleted the viglia/ref/ingest-functions-metrics-continuous-profiling branch November 4, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants