feat(action): Add sane defaults for failOn and commentOn#14
Conversation
GitHub checks now fail by default when critical or high severity findings are detected. Annotations are shown for medium+ severity findings. - Add `fail-on` input default to 'high' in action.yml - Add `comment-on` input with default 'medium' in action.yml - Wire up commentOn input in action code with proper fallback - Update warden.toml with explicit defaults section Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
security-reviewsecurity-review: No issues found No findings to report. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| ); | ||
| } | ||
|
|
||
| const validSeverities = ['critical', 'high', 'medium', 'low', 'info'] as const; |
There was a problem hiding this comment.
Duplicated severity validation list instead of reusing existing type
Low Severity
The validSeverities array duplicates the severity values already defined in SeveritySchema from src/types/index.ts. The CLI (src/cli/args.ts) correctly imports and uses SeveritySchema for validation, but this action code manually redefines the same list. This creates a maintenance burden where changes to valid severity levels need to be updated in multiple places. The existing SeveritySchema.options could be used instead.
1 participant
Summary
fail-on: 'high'so checks fail on critical/high severity findings out of the boxcomment-oninput with default'medium'to control annotation visibilitycommentOninput in action code with proper fallback from trigger config → action inputwarden.tomlwith explicit defaults section for documentationTest plan
🤖 Generated with Claude Code