Potential fix for code scanning alert no. 2: Workflow does not contain permissions#28
Merged
Potential fix for code scanning alert no. 2: Workflow does not contain permissions#28
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
security-reviewsecurity-review: Found 1 issue (1 info) No findings to report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/getsentry/warden/security/code-scanning/2
In general, the fix is to add an explicit
permissionsblock that grants only the minimal scopes required for this workflow. For a CI job that only checks out code, installs dependencies, and runs build/test steps,contents: readis typically sufficient. This can be specified either at the top level of the workflow (applied to all jobs) or within the specific job. Since there is only one job (build), either approach works; adding it at the root is simplest and clear.The best minimal fix without changing existing behavior is to add a workflow-level
permissionsblock just below the workflowname:(or anywhere at the root level), settingcontents: read. None of the steps need write access:actions/checkout,pnpm/action-setup, andactions/setup-nodeall function with read-only repository contents. No additional imports or dependencies are needed; this is purely a YAML configuration change within.github/workflows/ci.yml.Concretely:
Edit
.github/workflows/ci.yml.Insert:
after line 1 (
name: CI) and before theon:block (line 3).This will constrain the
GITHUB_TOKENfor all jobs in this workflow.Suggested fixes powered by Copilot Autofix. Review carefully before merging.