fix: Add testing-guidelines and fix skill-writer#49
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| name = "testing-guidelines" | ||
| event = "pull_request" | ||
| actions = ["opened", "synchronize", "reopened"] | ||
| skill = "testing-guidelines" |
There was a problem hiding this comment.
Trigger references skill not designed for PR analysis
Medium Severity
The new warden.toml trigger runs the testing-guidelines skill on every pull request, but this skill is structured as a developer reference guide for writing tests, not as an automated PR analysis skill. Unlike find-bugs and security-review, it lacks allowed-tools, task instructions ("You are a X analyzing code changes"), severity levels, and output requirements. The skill says "Follow these principles when writing tests" — guidance for agents, not analysis instructions. Running it as an automated trigger may produce unpredictable or unhelpful results.
Additional Locations (1)
|
|
||
| Generate valid Warden skill definitions from natural language descriptions. | ||
| --- | ||
| name: Skill Writer |
There was a problem hiding this comment.
Skill name mismatches directory naming convention
Low Severity
The skill-writer skill uses name: Skill Writer (title case with space) in the frontmatter, but its directory is skill-writer (kebab-case). All other skills follow the convention where the frontmatter name matches the directory name exactly (e.g., find-bugs, security-review, testing-guidelines). This mismatch breaks skill discovery: discoverAllSkills stores skills by frontmatter name, so looking up by "skill-writer" fails since the key is "Skill Writer". The name in the frontmatter should be skill-writer to match the directory.
1 participant
No description provided.