fix(release): Run CI on release branches for Craft artifacts#92
Merged
Conversation
CI uploads artifacts keyed by commit SHA, but craft prepare creates release commits on release/* branches. Without CI running on those branches, no artifacts exist for the release commit SHA, causing craft publish to fail. Matches sentry-mcp's approach: run CI on both main and release/* branches so artifacts are uploaded for release commits. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Craft publish fails when it can't find npm artifacts for the release commit. The root cause is that CI only ran on
main, butcraft preparecreates release commits onrelease/*branches, so no artifacts were uploaded for those commit SHAs.This matches the approach used by sentry-mcp: run CI on both
mainandrelease/*branches so artifacts are uploaded when release commits are pushed.The previous fix (#91) added artifact upload to CI, which was correct. This ensures CI actually runs on release commits.
Fixes the "Can't find any artifacts" error during craft publish.