playonlinux: Housekeeping (#1430)

**Summary** - Install appstream metadata (Part of #1389) - Added homepage key (Part of #411) - Use patched upstream desktop file - Use patched upstream Makefile **Test Plan** - Verify metadata with `appstream-builder --packages-dir=. --include-failed -v` - Verify homepage loads relevant information - Make sure app icon switch properly depending on icon theme (Tested on GNOME, Budgie, Plasma) - Install `foobar2000` on Budgie VM **Checklist** - [x] Package was built and tested against unstable
getsolus · Jan 25, 2024 · 1eadb58 · 1eadb58
2 parents 6b5c76f + ce9150d
commit 1eadb58
Show file tree

Hide file tree

Showing 8 changed files with 111 additions and 25 deletions.
diff --git a/packages/p/playonlinux/abi_used_libs b/packages/p/playonlinux/abi_used_libs
@@ -0,0 +1,3 @@
+libGL.so.1
+libX11.so.6
+libc.so.6
diff --git a/packages/p/playonlinux/abi_used_symbols b/packages/p/playonlinux/abi_used_symbols
@@ -0,0 +1,11 @@
+libGL.so.1:glXChooseVisual
+libGL.so.1:glXCreateContext
+libGL.so.1:glXIsDirect
+libX11.so.6:XFree
+libX11.so.6:XOpenDisplay
+libc.so.6:__libc_start_main
+libc.so.6:__stack_chk_fail
+libc.so.6:exit
+libc.so.6:fwrite
+libc.so.6:puts
+libc.so.6:stderr
diff --git a/packages/p/playonlinux/files/0001-patch-Makefile.patch b/packages/p/playonlinux/files/0001-patch-Makefile.patch
@@ -0,0 +1,56 @@
+From d7aabb70b991a8c9e262ad8adbe4bc33fa123f02 Mon Sep 17 00:00:00 2001
+From: Muhammad Alfi Syahrin <malfisya.dev@hotmail.com>
+Date: Thu, 25 Jan 2024 14:42:35 +0700
+Subject: [PATCH] patch Makefile
+
+---
+ Makefile | 20 +++++++++++---------
+ 1 file changed, 11 insertions(+), 9 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index a8d81b8..f3cfd83 100644
+--- a/Makefile
++++ b/Makefile
+@@ -31,7 +31,7 @@ DESTDIR ?= # root dir
+
+ sharedir := $(DESTDIR)$(PREFIX)/share
+ bindir := $(DESTDIR)$(PREFIX)/bin
+-execdir := $(DESTDIR)$(PREFIX)/libexec
++execdir := bindir
+
+
+ all: build
+@@ -58,20 +58,22 @@ build:
+ install:
+ 	install -d $(bindir)
+ 	install -d $(execdir)
+-	install -d $(sharedir)/pixmaps
++	install -d $(sharedir)/icons/hicolor/128x128/apps
++	install -d $(sharedir)/icons/hicolor/32x32/apps
++	install -d $(sharedir)/icons/hicolor/16x16/apps
+ 	install -d $(sharedir)/applications
+-	install -d $(sharedir)/appdata
+-	install -d $(sharedir)/playonlinux/bin
++	install -d $(sharedir)/metainfo
++	install -d $(sharedir)/playonlinux
+ 	install -d $(sharedir)/man/man1
+ 	install -d $(sharedir)/locale
+ 	$(GZIP) -c ./doc/playonlinux-pkg.1 > $(sharedir)/man/man1/playonlinux-pkg.1.gz
+ 	$(GZIP) -c ./doc/playonlinux.1 > $(sharedir)/man/man1/playonlinux.1.gz
+ 	cp ./etc/PlayOnLinux.desktop $(sharedir)/applications/PlayOnLinux.desktop
+-	cp ./etc/PlayOnLinux.appdata.xml $(sharedir)/appdata/PlayOnLinux.appdata.xml
+-	cp ./etc/playonlinux.png $(sharedir)/pixmaps/playonlinux.png
+-	cp ./etc/playonlinux16.png $(sharedir)/pixmaps/playonlinux16.png
+-	cp ./etc/playonlinux32.png $(sharedir)/pixmaps/playonlinux32.png
+-	cp ./bin/{playonlinux,playonlinux-pkg} $(bindir)/
++	cp ./etc/PlayOnLinux.appdata.xml $(sharedir)/metainfo/PlayOnLinux.appdata.xml
++	cp ./etc/playonlinux.png $(sharedir)/icons/hicolor/128x128/apps/playonlinux.png
++	cp ./etc/playonlinux16.png $(sharedir)/icons/hicolor/16x16/apps/playonlinux.png
++	cp ./etc/playonlinux32.png $(sharedir)/icons/hicolor/32x32/apps/playonlinux.png
++	cp -p ./bin/{playonlinux,playonlinux-pkg} $(bindir)/
+ 	cp ./bin/playonlinux-check_dd $(execdir)/
+ 	cp ./{playonlinux*,README.md,TRANSLATORS,CHANGELOG.md,LICENCE} $(sharedir)/playonlinux/
+ 	cp -R ./{bash,etc,lib,plugins,python,resources,tests} $(sharedir)/playonlinux/
+-- 
+2.43.0
+
diff --git a/packages/p/playonlinux/files/0002-patch-desktop-file.patch b/packages/p/playonlinux/files/0002-patch-desktop-file.patch
@@ -0,0 +1,23 @@
+From 8c91c14e582e494674fdbd9e3e2b1a88c0eab947 Mon Sep 17 00:00:00 2001
+From: Muhammad Alfi Syahrin <malfisya.dev@hotmail.com>
+Date: Thu, 25 Jan 2024 14:43:19 +0700
+Subject: [PATCH] patch desktop file
+
+---
+ etc/PlayOnLinux.desktop | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/etc/PlayOnLinux.desktop b/etc/PlayOnLinux.desktop
+index 490108c..f2ceba1 100644
+--- a/etc/PlayOnLinux.desktop
++++ b/etc/PlayOnLinux.desktop
+@@ -5,4 +5,6 @@ Comment=Front-end application for the wine
+ Type=Application
+ Exec=playonlinux %F
+ Icon=playonlinux
++Terminal=false
++StartupWMClass=PlayOnLinux
+ Categories=Utility;Emulator;
+-- 
+2.43.0
+
diff --git a/packages/p/playonlinux/files/playonlinux.desktop b/packages/p/playonlinux/files/playonlinux.desktop
diff --git a/packages/p/playonlinux/files/series b/packages/p/playonlinux/files/series
@@ -0,0 +1,2 @@
+0001-patch-Makefile.patch
+0002-patch-desktop-file.patch
diff --git a/packages/p/playonlinux/package.yml b/packages/p/playonlinux/package.yml
@@ -1,8 +1,9 @@
 name       : playonlinux
 version    : '4.4'
-release    : 21
+release    : 22
 source     :
     - https://github.com/PlayOnLinux/POL-POM-4/archive/refs/tags/4.4.tar.gz : a3536243772002d17b9c5fcfd616844134bcfe126ce7b7b24eb971ba1f63365d
+homepage   : https://www.playonlinux.com/
 license    : GPL-3.0-or-later
 component  : games
 summary    : PlayOnLinux is a piece of software which allows you to easily install and use numerous games and apps
@@ -23,10 +24,8 @@ rundeps    :
     - wine-32bit
     - wxPython
 setup      : |
-    cp $pkgfiles/Makefile .
+    %apply_patches
 build      : |
     %make
 install    : |
     %make_install
-    rm $installdir/usr/share/applications/PlayOnLinux.desktop
-    install -D -m 00644 $pkgfiles/playonlinux.desktop $installdir/usr/share/applications/playonlinux.desktop
diff --git a/packages/p/playonlinux/pspec_x86_64.xml b/packages/p/playonlinux/pspec_x86_64.xml
@@ -1,16 +1,17 @@
 <PISI>
     <Source>
         <Name>playonlinux</Name>
+        <Homepage>https://www.playonlinux.com/</Homepage>
         <Packager>
-            <Name>Silke Hofstra</Name>
-            <Email>silke@slxh.eu</Email>
+            <Name>Muhammad Alfi Syahrin</Name>
+            <Email>malfisya.dev@hotmail.com</Email>
         </Packager>
         <License>GPL-3.0-or-later</License>
         <PartOf>games</PartOf>
         <Summary xml:lang="en">PlayOnLinux is a piece of software which allows you to easily install and use numerous games and apps</Summary>
         <Description xml:lang="en">PlayOnLinux is a piece of software which allows you to easily install and use numerous games and apps designed to run with Microsoft Windows.
 </Description>
-        <Archive type="binary" sha1sum="79eb0752a961b8e0d15c77d298c97498fbc89c5a">https://getsol.us/sources/README.Solus</Archive>
+        <Archive type="binary" sha1sum="79eb0752a961b8e0d15c77d298c97498fbc89c5a">https://sources.getsol.us/README.Solus</Archive>
     </Source>
     <Package>
         <Name>playonlinux</Name>
@@ -21,7 +22,10 @@
         <Files>
             <Path fileType="executable">/usr/bin/playonlinux</Path>
             <Path fileType="executable">/usr/bin/playonlinux-pkg</Path>
-            <Path fileType="data">/usr/share/applications/playonlinux.desktop</Path>
+            <Path fileType="data">/usr/share/applications/PlayOnLinux.desktop</Path>
+            <Path fileType="data">/usr/share/icons/hicolor/128x128/apps/playonlinux.png</Path>
+            <Path fileType="data">/usr/share/icons/hicolor/16x16/apps/playonlinux.png</Path>
+            <Path fileType="data">/usr/share/icons/hicolor/32x32/apps/playonlinux.png</Path>
             <Path fileType="localedata">/usr/share/locale/ar/LC_MESSAGES/pol.mo</Path>
             <Path fileType="localedata">/usr/share/locale/ast/LC_MESSAGES/pol.mo</Path>
             <Path fileType="localedata">/usr/share/locale/bg/LC_MESSAGES/pol.mo</Path>
@@ -71,9 +75,7 @@
             <Path fileType="localedata">/usr/share/locale/zh_TW/LC_MESSAGES/pol.mo</Path>
             <Path fileType="man">/usr/share/man/man1/playonlinux-pkg.1.gz</Path>
             <Path fileType="man">/usr/share/man/man1/playonlinux.1.gz</Path>
-            <Path fileType="data">/usr/share/pixmaps/playonlinux.png</Path>
-            <Path fileType="data">/usr/share/pixmaps/playonlinux16.png</Path>
-            <Path fileType="data">/usr/share/pixmaps/playonlinux32.png</Path>
+            <Path fileType="data">/usr/share/metainfo/PlayOnLinux.appdata.xml</Path>
             <Path fileType="data">/usr/share/playonlinux/CHANGELOG.md</Path>
             <Path fileType="data">/usr/share/playonlinux/LICENCE</Path>
             <Path fileType="data">/usr/share/playonlinux/README.md</Path>
@@ -411,12 +413,12 @@
         </Files>
     </Package>
     <History>
-        <Update release="21">
-            <Date>2023-09-16</Date>
+        <Update release="22">
+            <Date>2024-01-25</Date>
             <Version>4.4</Version>
             <Comment>Packaging update</Comment>
-            <Name>Silke Hofstra</Name>
-            <Email>silke@slxh.eu</Email>
+            <Name>Muhammad Alfi Syahrin</Name>
+            <Email>malfisya.dev@hotmail.com</Email>
         </Update>
     </History>
 </PISI>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		0001-patch-Makefile.patch
		0002-patch-desktop-file.patch