Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitoring.yml to all packages that are still without it #4121

Open
malfisya opened this issue Oct 21, 2024 · 0 comments
Open

Add monitoring.yml to all packages that are still without it #4121

malfisya opened this issue Oct 21, 2024 · 0 comments
Labels
Good First Issue Issue that is good for someone new to the Solus project to try to tackle Type: Chore Not a feature or a bug

Comments

@malfisya
Copy link
Member

malfisya commented Oct 21, 2024 •
edited
Loading

A monitoring.yml file is used by Solus package to enable automatic scanning for new releases and security advisories. It is included in the directory of the relevant packages alongside package.yml, pspec*.xml, and MAINTAINERS.md. Read more about it on our Help Center.

You can find all the packages that are still without monitoring.yml by running this command:

# Replace solus-builds for the directory you have in your system
cd solus-builds/packages
find . -maxdepth 2 -mindepth 2  ! -exec sh -c 'test -e "$1"/monitoring.yml' sh {} \; -print

Guidance on fixing

  • One commit per package, but multiple commits (packages) on one Pull Request is OK
  • No need to bump and rebuild the package, our build tooling does not read monitoring.yml
  • Be sure to check for a CPE, even though many packages will not have one.

The list
@malfisya malfisya added Type: Chore Not a feature or a bug Good First Issue Issue that is good for someone new to the Solus project to try to tackle labels Oct 21, 2024
@github-project-automation github-project-automation bot moved this to Triage in Solus Oct 21, 2024
@malfisya malfisya mentioned this issue Oct 21, 2024
Merged
@silkeh silkeh mentioned this issue Oct 24, 2024
Merged
1 task
silkeh added a commit that referenced this issue Oct 25, 2024
@silkeh
ci/package_checks: Add check for monitoring.yml (#4149)
38242c1 
**Summary**

Add a check that errors when `monitoring.yml` does not exist. This makes
the existence of `monitoring.yml` mandatory for all packages.

Related to #4121

**Test Plan**

Run manually against a known bad package:

```console
$ common/CI/package_checks.py packages/g/glog/package.yml 
Checking files: packages/g/glog/package.yml
Found 4 result(s), 1 warnings and 2 error(s)
INF packages/g/glog/package.yml:1: This package is included in the ISO. Consider validating the functionality in a newly built ISO.
ERR packages/g/glog/package.yml:1: `homepage` is not set
ERR packages/g/glog/package.yml:1: `monitoring.yml` is missing
WRN packages/g/glog/package.yml:1: Package release is not incremented by 1
```

Run manually against a known good package:

```console
$ common/CI/package_checks.py packages/l/linux-current/package.yml 
Checking files: packages/l/linux-current/package.yml
Found 2 result(s), 1 warnings and 0 error(s)
INF packages/l/linux-current/package.yml:1: This package is included in the ISO. Consider validating the functionality in a newly built ISO.
WRN packages/l/linux-current/package.yml:1: Package release is not incremented by 1
```

**Checklist**

- [x] Package was built and tested against unstable
malfisya added a commit that referenced this issue Nov 5, 2024
@malfisya
font-firacode: Housekeeping
bfdaa1b 
**Summary**

- Add appstream metainfo (Part of #449)
- Add monitoring.yml (Part of #4121)
@malfisya malfisya mentioned this issue Nov 5, 2024
Merged
1 task
malfisya added a commit that referenced this issue Nov 6, 2024
@malfisya
font-weather-icons: Housekeeping
ffc6ec4 
**Summary**

- Only ship .otf files
- Add appstream metainfo (Part of #449)
- Add monitoring.yml (Part of #4121)
@malfisya malfisya mentioned this issue Nov 6, 2024
Merged
1 task
malfisya added a commit that referenced this issue Nov 6, 2024
@malfisya
font-firago: Housekeeping
99190b9 
**Summary**

- Only ship .otf files
- Add appstream metainfo (Part of #449)
- Add monitoring.yml (Part of #4121)
@malfisya malfisya mentioned this issue Nov 6, 2024
Merged
1 task
@malfisya malfisya pinned this issue Nov 7, 2024
uni-dos added a commit to uni-dos/solus-packages that referenced this issue Nov 11, 2024
@uni-dos
lite-xl: Housekeeping
5f35fdf 
**Summary**
* add monitoring.yml (Part of getsolus#4121)
@uni-dos uni-dos mentioned this issue Nov 11, 2024
Merged
1 task
@malfisya malfisya moved this from Triage to Ready in Solus Nov 12, 2024
malfisya added a commit that referenced this issue Nov 12, 2024
@malfisya
ibus-bamboo: Housekeeping
f7048b4 
- Add replace key to remove ibus-unikey
- Add monitoring.yml (Part of #4121)
malfisya added a commit that referenced this issue Nov 12, 2024
@malfisya
pspp: Update to v2.0.1
246cb0a 
**Summary**

- Full changelog can be read [here](http://git.savannah.gnu.org/cgit/pspp.git/plain/NEWS?h=v2.0.1)
- Add monitoring.yml (Part of #4121)

Resolves #4175
malfisya added a commit that referenced this issue Nov 13, 2024
@malfisya
xsd: Housekeeping
d08a33e 
**Summary**

- Fix build (Resolves #3155)
- Add `homepage` key to `package.yml` (Part of #411)
- Add monitoring.yml (Part of #4121)
@malfisya malfisya mentioned this issue Nov 13, 2024
Merged
1 task
malfisya added a commit that referenced this issue Nov 13, 2024
@malfisya
vinagre: Housekeeping
3b7d792 
**Summary**

- Fix build
- Change homepage (Part of #4116)
- Add monitoring.yml (Part of #4121)
@malfisya malfisya mentioned this issue Nov 13, 2024
Merged
1 task
malfisya added a commit that referenced this issue Nov 13, 2024
@malfisya
vinagre: Fix builds and housekeeping
e2e07dd 
**Summary**

- Fix build
- Change homepage (Part of #4116)
- Add monitoring.yml (Part of #4121)
malfisya added a commit that referenced this issue Nov 13, 2024
@malfisya
xsd: Fix build and housekeeping
6fecc8e 
**Summary**

- Fix build (Resolves #3155)
- Add `homepage` key to `package.yml` (Part of #411)
- Add monitoring.yml (Part of #4121)
malfisya added a commit that referenced this issue Nov 14, 2024
@malfisya
[NFC] repo-wide: Add monitoring.yml
90a0db4 
**Summary**

Add monitoring.yml (Part of #4121)
@malfisya malfisya mentioned this issue Nov 14, 2024
Merged
malfisya added a commit that referenced this issue Nov 14, 2024
@malfisya
[NFC] repo-wide: Add monitoring.yml
f42926b 
**Summary**

Add monitoring.yml (Part of #4121)
malfisya added a commit that referenced this issue Nov 14, 2024
@malfisya
[NFC] repo-wide: Add monitoring.yml
1edee95 
**Summary**

Add monitoring.yml (Part of #4121)
ermo added a commit that referenced this issue Nov 14, 2024
@ermo
[NFC] repo-wide: Add monitoring.yml (#4357)
8fba436 
**Summary**

<!-- Info on what this pull request updates/changes/etc -->
Add monitoring.yml (Part of #4121)

**Checklist**

- [n/a ] Package was built and tested against unstable
davidjharder pushed a commit that referenced this issue Nov 14, 2024
@malfisya @davidjharder
ibus-bamboo: Housekeeping
20de895 
- Add replace key to remove ibus-unikey
- Add monitoring.yml (Part of #4121)
@malfisya malfisya mentioned this issue Nov 15, 2024
Merged
1 task
aquilapl pushed a commit to aquilapl/packages that referenced this issue Nov 16, 2024
@uni-dos @aquilapl
lite-xl: Housekeeping
bc271cb 
**Summary**
* add monitoring.yml (Part of getsolus#4121)
aquilapl pushed a commit to aquilapl/packages that referenced this issue Nov 16, 2024
@malfisya @aquilapl
pspp: Update to v2.0.1
16f8502 
**Summary**

- Full changelog can be read [here](http://git.savannah.gnu.org/cgit/pspp.git/plain/NEWS?h=v2.0.1)
- Add monitoring.yml (Part of getsolus#4121)

Resolves getsolus#4175
aquilapl pushed a commit to aquilapl/packages that referenced this issue Nov 16, 2024
@malfisya @aquilapl
[NFC] repo-wide: Add monitoring.yml
ab4423e 
**Summary**

Add monitoring.yml (Part of getsolus#4121)
aquilapl pushed a commit to aquilapl/packages that referenced this issue Nov 16, 2024
@malfisya @aquilapl
ibus-bamboo: Housekeeping
9d2d391 
- Add replace key to remove ibus-unikey
- Add monitoring.yml (Part of getsolus#4121)
aquilapl pushed a commit to aquilapl/packages that referenced this issue Nov 16, 2024
@malfisya @aquilapl
vinagre: Fix builds and housekeeping
8ba010b 
**Summary**

- Fix build
- Change homepage (Part of getsolus#4116)
- Add monitoring.yml (Part of getsolus#4121)
aquilapl pushed a commit to aquilapl/packages that referenced this issue Nov 16, 2024
@malfisya @aquilapl
xsd: Fix build and housekeeping
3adca7d 
**Summary**

- Fix build (Resolves getsolus#3155)
- Add `homepage` key to `package.yml` (Part of getsolus#411)
- Add monitoring.yml (Part of getsolus#4121)
malfisya pushed a commit to aquilapl/packages that referenced this issue Nov 22, 2024
@aquilapl @malfisya
gnome-tetravex: Housekeeping
8874dfb 
**Summary**

- Change homepage (Part of getsolus#4116)
- Add monitoring.yml (Part of getsolus#4121)
@malfisya malfisya mentioned this issue Nov 22, 2024
Merged
1 task
malfisya added a commit that referenced this issue Nov 24, 2024
@malfisya
glog: Fix build & housekeeping
5fe5c30 
**Summary**

- Fix build (Resolves #2225)
- Add `homepage` key to `package.yml` (Part of #411)
- Add monitoring.yml (Part of #4121)
@malfisya malfisya mentioned this issue Nov 24, 2024
Merged
2 tasks
malfisya added a commit that referenced this issue Nov 24, 2024
@malfisya
glog: Fix build & housekeeping
76add4a 
**Summary**

- Fix build
- Add `homepage` key to `package.yml` (Part of #411)
- Add monitoring.yml (Part of #4121)
@EbonJaeger EbonJaeger mentioned this issue Dec 5, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Issue that is good for someone new to the Solus project to try to tackle Type: Chore Not a feature or a bug
Projects
Solus
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
1 participant
@malfisya