Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glog: Update to 0.7.1 #3376

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

glog: Update to 0.7.1 #3376

wants to merge 1 commit into from

Conversation

uni-dos
Copy link
Contributor

@uni-dos uni-dos commented Jul 20, 2024

Fixes #2225.

Summary

  • changelog
  • added homepage
  • build using cmake/ninja

Test Plan

Ensure pspec contains homepage tag

Checklist

  • Package was built and tested against unstable

**Summary**

- [changelog](https://github.com/google/glog/releases/tag/v0.7.1)
- added homepage
- build using cmake/ninja
- add monitoring.yml
@androidnisse
Copy link
Contributor

Resolves #2225

@GZGavinZhao
Copy link
Member

This change feels weird. Why was the ABI changed from libglog.so.0 to libglog.so.2? If this is intended, this means that we would need to rebuild the following packages:

> rg libglog.so.0 -l --iglob=abi_used_libs
packages/o/opencv/abi_used_libs
packages/py/pytorch/abi_used_libs
packages/py/python-torchaudio/abi_used_libs
packages/c/ceres-solver/abi_used_libs
packages/l/librime/abi_used_libs

@uni-dos
Copy link
Contributor Author

uni-dos commented Jul 27, 2024

I'm not sure why the abi changed. I built glog without looking at the cmake file. The package is also 4 years old, maybe they had to make a change.

@malfisya
Copy link
Member

malfisya commented Aug 3, 2024

According to their 0.7.0 Release note :

Compatibility

glog aims to maintain source compatibility with the previous release. We did our best to ensure such compatibility in this version as well. However, downstream clients must recompile against the new glog version due to ABI incompatible changes.

So, I think the ABI change is intended. That means all revdeps need to be rebuild against this.

@uni-dos
Copy link
Contributor Author

uni-dos commented Aug 3, 2024

Is this a task that I can do or is it something the Solus team handles?

@malfisya
Copy link
Member

malfisya commented Aug 3, 2024

You can do it if you want. It is necessary for this PR to be merged. All the rebuilds must be included in this PR. If you don't feel like it, that's fine too.

@uni-dos
Copy link
Contributor Author

uni-dos commented Aug 3, 2024

To check packages that rely on it, do I just run eopkg info glog? Also, if those packages themselves have breaking abi changes, those will need to be rebuilt, correct?

@malfisya
Copy link
Member

malfisya commented Aug 3, 2024

So, in stack rebuild (this is what we call rebuilding revdeps), we usually avoids updating any of the packages to new version. It might get ballooned uncontrolably.

To check what must be rebuild : eopkg info is a good starting point. But sometime a package is only needed at build time, so it is not linked during runtime which eopkg info doesn't show. You can use ripgrep/rg the package repository to find all packages that has glog in the recipe. Or my prefered method, use vscode to search it.

Edit: I just realized Gavin already list all the package that needs to be rebuilt in previous comment.

Copy link
Contributor

@TraceyC77 TraceyC77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are required based on prior comments

@TraceyC77 TraceyC77 requested a review from GZGavinZhao August 17, 2024 20:03
@davidjharder
Copy link
Member

Hey @uni-dos have you had time to look at this? If you're not comfortable with the rebuilds, we can put this up for grabs

@uni-dos
Copy link
Contributor Author

uni-dos commented Oct 31, 2024

Sorry about that. I forgot about it and have been busy with school.

@davidjharder
Copy link
Member

I poked at this a bit. Some of the pytorch-ish revdeps were not happy. This will require some extra work. Gonna mark it as draft for now

@davidjharder davidjharder marked this pull request as draft November 4, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

glog
6 participants