-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glog: Update to 0.7.1 #3376
base: main
Are you sure you want to change the base?
glog: Update to 0.7.1 #3376
Conversation
**Summary** - [changelog](https://github.com/google/glog/releases/tag/v0.7.1) - added homepage - build using cmake/ninja - add monitoring.yml
Resolves #2225 |
This change feels weird. Why was the ABI changed from
|
I'm not sure why the abi changed. I built glog without looking at the cmake file. The package is also 4 years old, maybe they had to make a change. |
According to their 0.7.0 Release note :
So, I think the ABI change is intended. That means all revdeps need to be rebuild against this. |
Is this a task that I can do or is it something the Solus team handles? |
You can do it if you want. It is necessary for this PR to be merged. All the rebuilds must be included in this PR. If you don't feel like it, that's fine too. |
To check packages that rely on it, do I just run |
So, in stack rebuild (this is what we call rebuilding revdeps), we usually avoids updating any of the packages to new version. It might get ballooned uncontrolably. To check what must be rebuild : Edit: I just realized Gavin already list all the package that needs to be rebuilt in previous comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are required based on prior comments
Hey @uni-dos have you had time to look at this? If you're not comfortable with the rebuilds, we can put this up for grabs |
Sorry about that. I forgot about it and have been busy with school. |
I poked at this a bit. Some of the pytorch-ish revdeps were not happy. This will require some extra work. Gonna mark it as draft for now |
Fixes #2225.
Summary
Test Plan
Ensure pspec contains homepage tag
Checklist