Rebolt LLVM #4073
Draft
Rebolt LLVM #4073
+110
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** - llvm/llvm-project#111530 - This looks like a AArch64 specific fix and i'm assuming for now it's fine on X86.
1 task
|
May be wise to wait for some feedback on llvm/llvm-project#111530 before merging. I haven't spent any time understanding the code yet but it seems like it was a AArch64 specific fix. |
EbonJaeger
added
the
hacktoberfest-accepted
ermo
added
Topic: Plumbing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Revert (AArch64 specific?) commit that caused bolt instrumented binaries to segfault
Rebolt LLVM for 1.07x speedup on top of PGO+ThinLTO
Test Plan
Checklist