-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: Add License section with a historical note #4426
base: main
Are you sure you want to change the base?
Conversation
This should put to rest the question of under which licenses the Solus package recipes were originally shared. Signed-off-by: Rune Morling <ermo@serpentos.com>
62f779e
to
18e8cac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging up that commit and clearing up the licensing situation!
Well, I'm not sure the licensing situation has been entirely cleared up this way (I know I contributed recipes during a time when no licensing details were obvious), but it's certainly in a better state than before 😁 |
I think there are a few important questions that we need answers for before this can be merged. To give the background of the current packaging repository, from my understanding, it was originally a monorepo back in the EvolveOS days, before becoming the Solus packaging repository. That repository was licensed under GPL v2. In 2015, the repository was split into many separate repositories, and these repositories no longer contained explicit licenses. New packages, and thus new repositories, were added under the collective "package repository", all without explicit licenses. In 2023, all the existing package repositories were merged into a new single monorepo, still without a license stated. This history brings up several questions to me:
If the answer to No. 2 is "they cannot be considered GPL", then we cannot now slap GPL on the entire repository without contacting any contributor who made contributions during that time. Likewise, if the answer to No. 3 is that each repository can only be considered individually, then we cannot move forward with this PR. Thus, I think we need to do more due diligence and research before this can be merged. |
I added packages this year and then it were no license, so technically I would say I have the copyright and you can’t make them open source. But then comes the question, can’t other people update them? Just a thought here, just to complicate stuff. I’m all in for a clarification and if GPL is decided I’m okay with it. |
Yes. Definitely.
Generally, yes: when there's no license it's all rights reserved. In this case I think there's a couple of things might affect that:
Agreed, unless the license was stated somewhere on Phab or the contributing documentation these packages don't have an explicit license.
With unclear licenses for packages that have been created/updated since the split.
Very strictly taken you can't do anything with a copyrighted package except for throwing it away and creating a new one. My suggestion would be to reword the copyright statement a bit:
And for the historical note:
Additionally, we could add the following checkbox to the MR template, which would clean up most of this mess:
As an aside: we could take this opportunity to re-license if we feel like it 😅 |
The more I think about it, the more I think that this is the best avenue forward. Even if we decided to keep GPLv2 for some reason, I would feel much better about formally going through that process and being pretty sure that everything is good, than the murky situation we find ourselves in now. |
Summary
This should put to rest the question of under which license the Solus package recipes were originally shared.
Test Plan
Search the internet, fortuitously find reference to original commit where licensing was added to the old, original Solus package recipe repository from 2015.
Checklist