ypkg-install-deps: add --dry-run and --json #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GZGavinZhao
force-pushed
the
emit-json
branch
from
78b52b3
to
9b34216
Compare
|
Another approach, though I don't know how viable this is with ypkg and solbuild, is to install each package into a separate overlayfs layer. Then the individual package installations can be cached so you get even more savings. |
|
The only problem I could think of with this approach is how do we deal with triggers. By caching the entire root, we also cache the result of all trigger runs. |
The JSON dump has the following format:
```json
[
{
"name": "<package-name>",
"version": "<version>",
"release": "<relno>",
"packageHash": "<hash-of-eopkg>",
}
]
```
This not only dumps every single (including transitive) dependencies, but also
dumps the **currently installed** packages on the system. If we run this
inside the `solbuild` chroot and run `sudo eopkg up` prior to running `ypkg-
install-deps --dry-run --json package.yml`, we should get a (mostly)
reproducible JSON of packages that the root is comprised of. If we cache this
root identified by the hash of this JSON dump, we should be able to re-use
this cached root in `solbuild`, eliminating most if not all the time needed
for dependencies to install given that no dependency is changed.
Signed-off-by: Gavin Zhao <git@gzgz.dev>
GZGavinZhao
force-pushed
the
emit-json
branch
from
9b34216
to
9a01800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON dump has the following format:
[ { "name": "<package-name>", "version": "<version>", "release": "<relno>", "packageHash": "<hash-of-eopkg>", } ]This not only dumps every single (including transitive) dependencies, but also dumps the currently installed packages on the system. If we run this inside the
solbuildchroot and runsudo eopkg upprior to runningypkg-install-deps --dry-run --json package.yml, we should get a (mostly) reproducible JSON of packages that the root is comprised of. If we cache this root identified by the hash of this JSON dump, we should be able to re-use this cached root insolbuild, eliminating most if not all the time needed for dependencies to install given that no dependency is changed.