support for age identity with passphrase #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszduda23
changed the title
felixfontein
reviewed
Jan 2, 2024
…-dfc8ceccf9 build(deps): Bump the go group with 7 updates
|
@felixfontein would you mind review again? |
There was a problem hiding this comment.
Mering #1692 introduced conflicts in keysource_test.go; my guess is that both PRs added something at the end which caused this, so it should be easy to fix.
Signed-off-by: Tomasz Duda <tomaszduda23@gmail.com>
Signed-off-by: Tomasz Duda <tomaszduda23@gmail.com>
Fixed. |
Signed-off-by: Tomasz Duda <tomaszduda23@gmail.com>
Signed-off-by: Tomasz Duda <tomaszduda23@gmail.com>
felixfontein
approved these changes
Feb 23, 2025
|
(I'll wait until tomorrow with merging this to give others a chance to comment. In case anyone else wants to take a look, and doesn't have time til then, please write it here, then I'll wait longer. CC @getsops/maintainers.) |
|
@tomaszduda23 thanks a lot for your contribution and patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #933. It is basically rip of from https://github.com/FiloSottile/age/blob/101cc8676386b0503571a929a88618cae2f0b1cd/cmd/age/parse.go#L143. It looks that sops already support reading passwords similar way for PGP
It also support password prompt by gpg-agent. It requires merge of getsops/gopgagent#1