Skip to content

Warn user about .yml config file extension #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
onnimonni wants to merge 2 commits into from
Closed

Warn user about .yml config file extension #1798

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4619e54
Add support for .yml file extension in config file
onnimonni Mar 13, 2025
f0ea3ac
Remove support for .yml config extension and just log warning instead
onnimonni Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@
for i := 0; i < maxDepth; i++ {
_, err := fs.Stat(path.Join(filepath, configFileName))
if err != nil {
// Check if user mispelled '.sops.yaml'
warnWrongConfigFileExtension(filepath)
filepath = path.Join(filepath, "..")
} else {
return path.Join(filepath, configFileName), nil
Expand All @@ -55,6 +57,14 @@
return "", fmt.Errorf("Config file not found")
}

func warnWrongConfigFileExtension(filepath string) {
_, err :=
fs.Stat(path.Join(filepath, ".sops.yml"))
if err == nil {
log.Printf("warning: Found unsupported '.sops.yml' config file. Rename it to '.sops.yaml' or use '--config .sops.yml' flag")

Check failure on line 64 in config/config.go

View workflow job for this annotation

GitHub Actions / Build and test linux amd64 1.22 

undefined: log

Check failure on line 64 in config/config.go

View workflow job for this annotation

GitHub Actions / Build and test linux amd64 1.23 

undefined: log

Check failure on line 64 in config/config.go

View workflow job for this annotation

GitHub Actions / Build and test linux arm64 1.22 

undefined: log

Check failure on line 64 in config/config.go

View workflow job for this annotation

GitHub Actions / Build and test linux arm64 1.23 

undefined: log

Check failure on line 64 in config/config.go

View workflow job for this annotation

GitHub Actions / Build and test darwin amd64 1.22 

undefined: log

Check failure on line 64 in config/config.go

View workflow job for this annotation

GitHub Actions / Build and test darwin amd64 1.23 

undefined: log

Check failure on line 64 in config/config.go

View workflow job for this annotation

GitHub Actions / Build and test darwin arm64 1.22 

undefined: log

Check failure on line 64 in config/config.go

View workflow job for this annotation

GitHub Actions / Build and test darwin arm64 1.23 

undefined: log

Check failure on line 64 in config/config.go

View workflow job for this annotation

GitHub Actions / Build and test windows amd64 1.22 

undefined: log
}
}

type DotenvStoreConfig struct{}

type INIStoreConfig struct{}
Expand Down
Loading