-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an output flag for saving the output to a specified file #387
Conversation
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
- Coverage 43.37% 43.11% -0.26%
==========================================
Files 15 15
Lines 1969 1969
==========================================
- Hits 854 849 -5
- Misses 1039 1043 +4
- Partials 76 77 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch! This looks good, but I think it'd be nice to have documentation for this in the README. Would you mind documenting this feature?
We might want to add an end-to-end test for this, but I don't expect you to, since those tests are written in an entirely different language :). I'll see if I have time to add it to this PR myself.
@autrilla sure would love to add this flag to the documentation, can you point out to where should I add it in the readme? |
@hellozee I'd add it under "Usage", after section 2.12 (or whatever the current latest is). You can certainly go ahead and write a test for it! |
Rewrote output condition to something more idiomatic Go code
@autrilla Did I miss something? |
@hellozee I thought you wanted to add the functional tests for this. Let me know if you don't and I'll do it myself. |
@autrilla ohh I tried a couple of times to learn rust, but it didn't go too far, thought my C++ background would but nevertheless, writing tests in rust is not my thing, sadly, 😉 |
Fixes #386