Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an output flag for saving the output to a specified file #387

Merged
merged 8 commits into from
Nov 7, 2018
Merged

Added an output flag for saving the output to a specified file #387

merged 8 commits into from
Nov 7, 2018

Conversation

hellozee
Copy link
Contributor

Fixes #386

@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #387 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   43.37%   43.11%   -0.26%     
==========================================
  Files          15       15              
  Lines        1969     1969              
==========================================
- Hits          854      849       -5     
- Misses       1039     1043       +4     
- Partials       76       77       +1
Impacted Files Coverage Δ
stores/flatten.go 87.28% <0%> (-4.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d08a1...6ce0290. Read the comment docs.

Copy link
Contributor

@autrilla autrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! This looks good, but I think it'd be nice to have documentation for this in the README. Would you mind documenting this feature?

We might want to add an end-to-end test for this, but I don't expect you to, since those tests are written in an entirely different language :). I'll see if I have time to add it to this PR myself.

cmd/sops/main.go Outdated Show resolved Hide resolved
cmd/sops/main.go Outdated Show resolved Hide resolved
@hellozee
Copy link
Contributor Author

@autrilla sure would love to add this flag to the documentation, can you point out to where should I add it in the readme?
If no one is onto writing a test for it, I would like to give it a try, learning a new language isn't a bad thing afterall

@autrilla
Copy link
Contributor

@hellozee I'd add it under "Usage", after section 2.12 (or whatever the current latest is).

You can certainly go ahead and write a test for it!

cmd/sops/main.go Outdated Show resolved Hide resolved
cmd/sops/main.go Outdated Show resolved Hide resolved
@hellozee
Copy link
Contributor Author

hellozee commented Nov 6, 2018

@autrilla Did I miss something?

@autrilla
Copy link
Contributor

autrilla commented Nov 6, 2018

@hellozee I thought you wanted to add the functional tests for this. Let me know if you don't and I'll do it myself.

@hellozee
Copy link
Contributor Author

hellozee commented Nov 6, 2018

@autrilla ohh I tried a couple of times to learn rust, but it didn't go too far, thought my C++ background would but nevertheless, writing tests in rust is not my thing, sadly, 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants